Schema - Add base function for FiveFortyNine boolean search

diff --git a/CRM/Upgrade/Incremental/php/FiveFortyNine.php b/CRM/Upgrade/Incremental/php/FiveFortyNine.php
index 6b570a6f046892ae96571d2dc397523501ade08c..5d55e58fee5adc830f34fa7634bc262f22be3fe5 100644 (file)
--- a/CRM/Upgrade/Incremental/php/FiveFortyNine.php
+++ b/CRM/Upgrade/Incremental/php/FiveFortyNine.php
@@ -21,46 +21,14 @@
  */
 class CRM_Upgrade_Incremental_php_FiveFortyNine extends CRM_Upgrade_Incremental_Base {
 
-  /**
-   * @var string[][]
-   * Array (keyed by tableName) of boolean columns to make NOT NULL.
-   * @see self::changeBooleanColumn
-   */
-  private $booleanColumns = [
-    'civicrm_event' => [
-      'is_public' => "DEFAULT 1 COMMENT 'Public events will be included in the iCal feeds. Access to private event information may be limited using ACLs.'",
-      'is_online_registration' => "DEFAULT 0 COMMENT 'If true, include registration link on Event Info page.'",
-      'is_monetary' => "DEFAULT 0 COMMENT 'If true, one or more fee amounts must be set and a Payment Processor must be configured for Online Event Registration.'",
-      'is_map' => "DEFAULT 0 COMMENT 'Include a map block on the Event Information page when geocode info is available and a mapping provider has been specified?'",
-      'is_active' => "DEFAULT 0 COMMENT 'Is this Event enabled or disabled/cancelled?'",
-      'is_show_location' => "DEFAULT 1 COMMENT 'If true, show event location.'",
-      'is_email_confirm' => "DEFAULT 0 COMMENT 'If true, confirmation is automatically emailed to contact on successful registration.'",
-      'is_pay_later' => "DEFAULT 0 COMMENT 'if true - allows the user to send payment directly to the org later'",
-      'is_partial_payment' => "DEFAULT 0 COMMENT 'is partial payment enabled for this event'",
-      'is_multiple_registrations' => "DEFAULT 0 COMMENT 'if true - allows the user to register multiple participants for event'",
-      'allow_same_participant_emails' => "DEFAULT 0 COMMENT 'if true - allows the user to register multiple registrations from same email address.'",
-      'has_waitlist' => "DEFAULT 0 COMMENT 'Whether the event has waitlist support.'",
-      'requires_approval' => "DEFAULT 0 COMMENT 'Whether participants require approval before they can finish registering.'",
-      'allow_selfcancelxfer' => "DEFAULT 0 COMMENT 'Allow self service cancellation or transfer for event?'",
-      'is_template' => "DEFAULT 0 COMMENT 'whether the event has template'",
-      'is_share' => "DEFAULT 1 COMMENT 'Can people share the event through social media?'",
-      'is_confirm_enabled' => "DEFAULT 1 COMMENT 'If false, the event booking confirmation screen gets skipped'",
-      'is_billing_required' => "DEFAULT 0 COMMENT 'if true than billing block is required this event'",
-    ],
-    'civicrm_contribution' => [
-      'is_test' => "DEFAULT 0",
-      'is_pay_later' => "DEFAULT 0",
-      'is_template' => "DEFAULT 0 COMMENT 'Shows this is a template for recurring contributions.'",
-    ],
-    'civicrm_financial_account' => [
-      'is_header_account' => "DEFAULT 0 COMMENT 'Is this a header account which does not allow transactions to be posted against it directly, but only to its sub-accounts?'",
-      'is_deductible' => "DEFAULT 0 COMMENT 'Is this account tax-deductible?'",
-      'is_tax' => "DEFAULT 0 COMMENT 'Is this account for taxes?'",
-      'is_reserved' => "DEFAULT 0 COMMENT 'Is this a predefined system object?'",
-      'is_active' => "DEFAULT 1 COMMENT 'Is this property active?'",
-      'is_default' => "DEFAULT 0 COMMENT 'Is this account the default one (or default tax one) for its financial_account_type?'",
-    ],
-  ];
+  public static function findBooleanColumns(): array {
+    $r = [];
+    $files = CRM_Utils_File::findFiles(__DIR__ . '/FiveFortyNine', '*.bool.php');
+    foreach ($files as $file) {
+      $r = array_merge($r, require $file);
+    }
+    return $r;
+  }
 
   /**
    * Upgrade step; adds tasks including 'runSql'.
@@ -73,7 +41,7 @@ class CRM_Upgrade_Incremental_php_FiveFortyNine extends CRM_Upgrade_Incremental_
       'civicrm_contact_type', 'icon', "varchar(255) DEFAULT NULL COMMENT 'crm-i icon class representing this contact type'"
     );
     $this->addTask(ts('Upgrade DB to %1: SQL', [1 => $rev]), 'runSql', $rev);
-    foreach ($this->booleanColumns as $tableName => $columns) {
+    foreach (static::findBooleanColumns() as $tableName => $columns) {
       foreach ($columns as $columnName => $defn) {
         $this->addTask("Update $tableName.$columnName to be NOT NULL", 'changeBooleanColumn', $tableName, $columnName, $defn);
       }