CRM-16138 - CRM_Extensions_System - Include domain_id in cache paths

The extension cache (returned by CRM_Extension_System::getCache) is already
keyed off extensionDir, extensionUrl, civicrm_root, and several others.
This patch adds domain_id to the list.

The patch is derived from agileware's patch from 4.4. Notably, the original
patch only influenced mapper (not the other caches).

I don't really think this patch should be necessary. Firstly, there are
already many variables factored into the cache-key for 4.6+ (CRM-15788) --
one (or more) should get tripped in "single-database, multiple-codebase"
architecture.  Secondly, the extension list is not innately domain-based.

However, there are a dizzying range of variations on
multi-site/multi-domain, and I may not have a full appreciation for the one
that led to agileware's patch.  And (theoertically) there's no big downside
to including domain_id as part of the cache.

diff --git a/CRM/Extension/System.php b/CRM/Extension/System.php
index 1e09e10f02b3f4aebabb557d5909b621fa13cc74..7e5441f68a846424df25eef35c12faef03d6700c 100644 (file)
--- a/CRM/Extension/System.php
+++ b/CRM/Extension/System.php
@@ -52,6 +52,13 @@ class CRM_Extension_System {
    */
   private $_repoUrl = NULL;
 
+  /**
+   * @var array
+   *   Construction parameters. These are primarily retained so
+   *   that they can influence the cache name.
+   */
+  protected $parameters;
+
   /**
    * @param bool $fresh
    *   TRUE to force creation of a new system.
@@ -102,6 +109,9 @@ class CRM_Extension_System {
     if (!array_key_exists('cmsRootPath', $parameters)) {
       $parameters['cmsRootPath'] = $config->userSystem->cmsRootPath();
     }
+    if (!array_key_exists('domain_id', $parameters)) {
+      $parameters['domain_id'] = CRM_Core_Config::domainID();
+    }
     ksort($parameters); // guaranteed ordering - useful for md5(serialize($parameters))
 
     $this->parameters = $parameters;