Remove static caching in deprecated function that seems to break tests

diff --git a/CRM/Core/SelectValues.php b/CRM/Core/SelectValues.php
index 755bf848b9e508b6303665695afec5aa39572802..2830c67782be2e23f4c27cf813afd08fe9b5bff5 100644 (file)
--- a/CRM/Core/SelectValues.php
+++ b/CRM/Core/SelectValues.php
@@ -610,25 +610,22 @@ class CRM_Core_SelectValues {
    * @return array
    */
   public static function caseTokens($caseTypeId = NULL) {
-    static $tokens = NULL;
-    if (!$tokens) {
-      $tokens = [
-        '{case.id}' => ts('Case ID'),
-        '{case.case_type_id:label}' => ts('Case Type'),
-        '{case.subject}' => ts('Case Subject'),
-        '{case.start_date}' => ts('Case Start Date'),
-        '{case.end_date}' => ts('Case End Date'),
-        '{case.details}' => ts('Details'),
-        '{case.status_id:label}' => ts('Case Status'),
-        '{case.is_deleted:label}' => ts('Case is in the Trash'),
-        '{case.created_date}' => ts('Created Date'),
-        '{case.modified_date}' => ts('Modified Date'),
-      ];
+    $tokens = [
+      '{case.id}' => ts('Case ID'),
+      '{case.case_type_id:label}' => ts('Case Type'),
+      '{case.subject}' => ts('Case Subject'),
+      '{case.start_date}' => ts('Case Start Date'),
+      '{case.end_date}' => ts('Case End Date'),
+      '{case.details}' => ts('Details'),
+      '{case.status_id:label}' => ts('Case Status'),
+      '{case.is_deleted:label}' => ts('Case is in the Trash'),
+      '{case.created_date}' => ts('Created Date'),
+      '{case.modified_date}' => ts('Modified Date'),
+    ];
 
-      $customFields = CRM_Core_BAO_CustomField::getFields('Case', FALSE, FALSE, $caseTypeId);
-      foreach ($customFields as $id => $field) {
-        $tokens["{case.custom_$id}"] = "{$field['label']} :: {$field['groupTitle']}";
-      }
+    $customFields = CRM_Core_BAO_CustomField::getFields('Case', FALSE, FALSE, $caseTypeId);
+    foreach ($customFields as $id => $field) {
+      $tokens["{case.custom_$id}"] = "{$field['label']} :: {$field['groupTitle']}";
     }
     return $tokens;
   }