Fix e-notices in contribution_offline_receipt text by removing always-empty field

On looking to fix this enotice through the form it turned out the
contribution form does not have a field for this - so the formValues
will never hold receipt_text.

Hence this PR removes it from the template.

Other forms do seem to have this & I will separately add userText or similar to the model

diff --git a/xml/templates/message_templates/contribution_offline_receipt_html.tpl b/xml/templates/message_templates/contribution_offline_receipt_html.tpl
index f401782dc14500c68041d838af5e72ecf7ee48ff..2a220b5fa3093d392b13dfe68bd59beafb6e9b2d 100644 (file)
--- a/xml/templates/message_templates/contribution_offline_receipt_html.tpl
+++ b/xml/templates/message_templates/contribution_offline_receipt_html.tpl
@@ -21,11 +21,7 @@
   <tr>
    <td>
     {assign var="greeting" value="{contact.email_greeting_display}"}{if $greeting}<p>{$greeting},</p>{/if}
-    {if !empty($formValues.receipt_text)}
-     <p>{$formValues.receipt_text|htmlize}</p>
-    {else}
      <p>{ts}Below you will find a receipt for this contribution.{/ts}</p>
-    {/if}
    </td>
   </tr>
   <tr>

diff --git a/xml/templates/message_templates/contribution_offline_receipt_text.tpl b/xml/templates/message_templates/contribution_offline_receipt_text.tpl
index e5692d06423d58a8a721d5e8f05a33f6a77cbe2b..1f6ea39debbb47f851cde1befa200ed6cd96f3af 100644 (file)
--- a/xml/templates/message_templates/contribution_offline_receipt_text.tpl
+++ b/xml/templates/message_templates/contribution_offline_receipt_text.tpl
@@ -1,8 +1,6 @@
 {assign var="greeting" value="{contact.email_greeting_display}"}{if $greeting}{$greeting},{/if}
 
-{if !empty($formValues.receipt_text)}
-{$formValues.receipt_text}
-{else}{ts}Below you will find a receipt for this contribution.{/ts}{/if}
+{ts}Below you will find a receipt for this contribution.{/ts}
 
 ===========================================================
 {ts}Contribution Information{/ts}