Fix intermittent test fail on NULL array getting contaminated & causing later tests...
authoreileen <emcnaughton@wikimedia.org>
Fri, 14 Jun 2019 20:58:05 +0000 (16:58 -0400)
committereileen <emcnaughton@wikimedia.org>
Fri, 14 Jun 2019 23:17:06 +0000 (19:17 -0400)
CRM/Contact/BAO/Contact.php
CRM/Dedupe/Merger.php

index 2640fdedf95be7d61fe1fb9642bf87f5d2ecda0d..b7e5dace1253161524d0c7a14e09c7b2a0095c63 100644 (file)
@@ -1960,7 +1960,7 @@ ORDER BY civicrm_email.is_primary DESC";
    */
   public static function createProfileContact(
     &$params,
-    &$fields,
+    &$fields = [],
     $contactID = NULL,
     $addToGroupID = NULL,
     $ufGroupId = NULL,
index e6b07b91435a5d9c0d8586a73dccc89cd3196de6..20b5711a8a92f4ff4ca2a22789a5a85a1e04d9ca 100644 (file)
@@ -1679,8 +1679,8 @@ INNER JOIN  civicrm_membership membership2 ON membership1.membership_type_id = m
       if (!isset($submitted['suffix_id']) && !empty($migrationInfo['main_details']['suffix_id'])) {
         $submitted['suffix_id'] = $migrationInfo['main_details']['suffix_id'];
       }
-
-      CRM_Contact_BAO_Contact::createProfileContact($submitted, CRM_Core_DAO::$_nullArray, $mainId);
+      $null = [];
+      CRM_Contact_BAO_Contact::createProfileContact($submitted, $null, $mainId);
     }
     $transaction->commit();
     CRM_Utils_Hook::post('merge', 'Contact', $mainId);