Javascript treats '0' different to 0. '0' is a string, and doesn't seem to

match a boolean comparison.  Or at least you get some odd results.  I have
fancy highlighting off, and '0' makes it appear.  Also removed some odd
javascript:

  this.checked = !(this.checked)

on every message check box, what was this for?  Firefox makes that a stupid
bit of code, as you click on a check box, and it unchecks it immedately
making it impossible to select messages :)

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@9282 7612ce4b-ef26-0410-bec9-ea0150e637f0

diff --git a/templates/default/message_list.tpl b/templates/default/message_list.tpl
index e6cf2882fb1b3f94a1872d030c1ff2bef3f870ac..6e948f5a211e40f6e659d018f89c770e49200982 100644 (file)
--- a/templates/default/message_list.tpl
+++ b/templates/default/message_list.tpl
@@ -202,7 +202,7 @@ else
         switch ($iCol) {
           case SQM_COL_CHECK:
               if ($javascript_on) {
-                  echo '<input type="checkbox" name="toggleAll" title="'._("Toggle All").'" onclick="toggle_all(\''.$form_id."','".$fancy_index_highlite."','".$clickedColor.'\');" />';
+                  echo '<input type="checkbox" name="toggleAll" title="'._("Toggle All").'" onclick="toggle_all(\''.$form_id."',".$fancy_index_highlite.",'".$clickedColor.'\');" />';
               } else {
                   $link = $baseurl . "&amp;startMessage=$pageOffset&amp;&amp;checkall=";
                   if (sqgetGlobalVar('checkall',$checkall,SQ_GET)) {
@@ -271,7 +271,7 @@ else
                 $clickedColor = (!empty($color[16])) ? $color[16] : $color[2];
             }
             if ($javascript_on) {
-                $checkbox_javascript = ' onClick="this.checked = !this.checked;"';
+//                $checkbox_javascript = ' onClick="this.checked = !this.checked;"';
             }
             foreach ($aMessages as $iUid => $aMsg) {
                 echo $sLine;