dev/core#2758 fix task tiles
authorEileen McNaughton <emcnaughton@wikimedia.org>
Sun, 15 Aug 2021 22:01:07 +0000 (10:01 +1200)
committerEileen McNaughton <emcnaughton@wikimedia.org>
Sun, 15 Aug 2021 22:05:01 +0000 (10:05 +1200)
CRM/Core/Task.php
CRM/Member/Task.php

index aab7757d3e4f4890fff504e696cec829bd98945a..3ef3690a722ecb3d58016d31f9806d060328a562 100644 (file)
@@ -47,7 +47,7 @@ abstract class CRM_Core_Task {
    *
    * @var array
    */
-  public static $_tasks = NULL;
+  public static $_tasks = [];
 
   /**
    * @var string
index f9f7589ae8f3a25dc8425bca468b20d828ad0685..dd04d9e062f8875a7eb847ab42b673db9b793711 100644 (file)
@@ -151,7 +151,7 @@ class CRM_Member_Task extends CRM_Core_Task {
    *   set of tasks that are valid for the user
    */
   public static function permissionedTaskTitles($permission, $params = []) {
-    $tasks = self::getTitlesFilteredByPermission(self::$_tasks, $permission === CRM_Core_Permission::EDIT);
+    $tasks = self::getTitlesFilteredByPermission(self::tasks(), $permission === CRM_Core_Permission::EDIT);
     return parent::corePermissionedTaskTitles($tasks, $permission, $params);
   }
 
@@ -165,8 +165,7 @@ class CRM_Member_Task extends CRM_Core_Task {
    *   the set of tasks for a group of members
    */
   public static function getTask($value) {
-    self::tasks();
-    if (!$value || empty(self::$_tasks[$value])) {
+    if (!$value || empty(self::tasks()[$value])) {
       // Make the print task the default
       $value = self::TASK_PRINT;
     }