Fix eximon continuous updating with timestamped log-files.

Report and fix from Heiko Schlichting.

Fixes 1363.

diff --git a/doc/doc-txt/ChangeLog b/doc/doc-txt/ChangeLog
index 11079a2982dd5c4add324ce0e185d73767d54cbe..e0411bab63e5c3d5c0e22a3e1bc8663de743abe4 100644 (file)
--- a/doc/doc-txt/ChangeLog
+++ b/doc/doc-txt/ChangeLog
@@ -196,6 +196,12 @@ PP/20 Added force_command boolean option to pipe transport.
 JH/15 AUTH support on callouts (and hence cutthrough-deliveries).
       Bugzilla 321, 823.
 
+PP/21 Fix eximon continuous updating with timestamped log-files.
+      Broken in a format-string cleanup in 4.80, missed when I repaired the
+      other false fix of the same issue.
+      Report and fix from Heiko Schlichting.
+      Bugzilla 1363.
+
 
 Exim version 4.80.1
 -------------------

diff --git a/src/exim_monitor/em_log.c b/src/exim_monitor/em_log.c
index bd1d462bf9a071738c9bc6053995c97b64c49667..0441edd2eb84f0a7d61d158d46658fc7cc77149f 100644 (file)
--- a/src/exim_monitor/em_log.c
+++ b/src/exim_monitor/em_log.c
@@ -364,7 +364,9 @@ link count of zero on the currently open file. */
 if (log_datestamping)
   {
   uschar log_file_wanted[256];
-  string_format(log_file_wanted, sizeof(log_file_wanted), "%s", CS log_file);
+  /* Do *not* use "%s" here, we need the %D datestamp in the log_file to
+   *   be expanded! */
+  string_format(log_file_wanted, sizeof(log_file_wanted), CS log_file);
   if (Ustrcmp(log_file_wanted, log_file_open) != 0)
     {
     if (LOG != NULL)