Remove remaining places where unused variable is passed
authorEileen McNaughton <emcnaughton@wikimedia.org>
Mon, 19 Jun 2023 03:06:02 +0000 (15:06 +1200)
committerEileen McNaughton <emcnaughton@wikimedia.org>
Mon, 19 Jun 2023 03:06:02 +0000 (15:06 +1200)
CRM/Event/Form/ParticipantFeeSelection.php
CRM/Member/Form/Membership.php

index 883048922a78011d9b39304c053fab18e149b4ed..f0dcc7803f41748db5171908c46d762442613b59 100644 (file)
@@ -246,8 +246,7 @@ class CRM_Event_Form_ParticipantFeeSelection extends CRM_Core_Form {
     $params = $this->controller->exportValues($this->_name);
 
     $feeBlock = $this->_values['fee'];
-    $lineItems = $this->_values['line_items'];
-    CRM_Price_BAO_LineItem::changeFeeSelections($params, $this->_participantId, 'participant', $this->getContributionID(), $feeBlock, $lineItems);
+    CRM_Price_BAO_LineItem::changeFeeSelections($params, $this->_participantId, 'participant', $this->getContributionID(), $feeBlock);
     $this->contributionAmt = CRM_Core_DAO::getFieldValue('CRM_Contribute_BAO_Contribution', $this->getContributionID(), 'total_amount');
     // email sending
     if (!empty($params['send_receipt'])) {
index 7c5fee3228c30ab221c5efe45ad0aa7e855b05d5..8f6219125368e640ee3528ff014637a218af879e 100644 (file)
@@ -1395,8 +1395,6 @@ DESC limit 1");
         return;
       }
 
-      // fetch lineitems by updated membership ID
-      $lineItems = CRM_Price_BAO_LineItem::getLineItems($this->getMembershipID(), 'membership');
       // retrieve the related contribution ID
       $contributionID = CRM_Core_DAO::getFieldValue(
         'CRM_Member_DAO_MembershipPayment',
@@ -1423,8 +1421,7 @@ DESC limit 1");
         $this->getMembershipID(),
         'membership',
         $contributionID,
-        $priceSetDetails['fields'],
-        $lineItems
+        $priceSetDetails['fields']
       );
       CRM_Core_Session::setStatus(ts('Associated contribution is updated on membership type change.'), ts('Success'), 'success');
     }