phpcs fixes

diff --git a/CRM/Contribute/BAO/Contribution/Utils.php b/CRM/Contribute/BAO/Contribution/Utils.php
index 6e016da51e43d382ca46e6f0b2f35d61223d1e58..687fe4150dc7742b6c2ee48b4662578b60e1fe4e 100644 (file)
--- a/CRM/Contribute/BAO/Contribution/Utils.php
+++ b/CRM/Contribute/BAO/Contribution/Utils.php
@@ -208,7 +208,6 @@ class CRM_Contribute_BAO_Contribution_Utils {
       $form->_values,
       $contribution->is_test
     );
-    return;
   }
 
   /**

diff --git a/CRM/Core/Payment.php b/CRM/Core/Payment.php
index 860eaa3f67d91aeb7e69c931f44c8d4fc4d22bf4..6dbb4660a81ac927e4616b253c09d8ed4fdd0406 100644 (file)
--- a/CRM/Core/Payment.php
+++ b/CRM/Core/Payment.php
@@ -624,16 +624,15 @@ abstract class CRM_Core_Payment {
    *
    * Does a server to server payment transaction.
    *
-   * Note that doPayment will throw an exception so the code may need to be modified
-   *
    * @param array $params
    *   Assoc array of input parameters for this transaction.
    *
    * @return array
-   *   the result in an nice formatted array (or an error object)
-   * @abstract
+   *   the result in an nice formatted array (or an error object - but throwing exceptions is preferred)
    */
-  protected function doDirectPayment(&$params) {}
+  protected function doDirectPayment(&$params) {
+    return $params;
+  }
 
   /**
    * Process payment - this function wraps around both doTransferPayment and doDirectPayment.