(REF) CiviEnvBuilder - Simplify `$name` calculation

Tweaking the `$name` is theoretically useful if you have entirely
independent data-sets that happen to live in the same DB.  In practice, we
only use CiviEnvBuilder to manage Civi-related data-sets.

diff --git a/Civi/Test.php b/Civi/Test.php
index dfa4d31c307c5d0bd08359c54502cd070275909f..cd01116417dfa45b6f80587940ff4b4a38f02fca 100644 (file)
--- a/Civi/Test.php
+++ b/Civi/Test.php
@@ -110,7 +110,7 @@ class Test {
    */
   public static function headless() {
     $civiRoot = dirname(__DIR__);
-    $builder = new \Civi\Test\CiviEnvBuilder('CiviEnvBuilder');
+    $builder = new \Civi\Test\CiviEnvBuilder();
     $builder
       ->callback(function ($ctx) {
         if (CIVICRM_UF !== 'UnitTests') {
@@ -139,7 +139,7 @@ class Test {
    * @return \Civi\Test\CiviEnvBuilder
    */
   public static function e2e() {
-    $builder = new \Civi\Test\CiviEnvBuilder('CiviEnvBuilder');
+    $builder = new \Civi\Test\CiviEnvBuilder();
     $builder
       ->callback(function ($ctx) {
         if (CIVICRM_UF === 'UnitTests') {

diff --git a/Civi/Test/CiviEnvBuilder.php b/Civi/Test/CiviEnvBuilder.php
index 8bce9d1fbf5e6a57d03e389ee92330d33b6555b8..2da7268bcc924e4e89136787cb91c32ae25bd24e 100644 (file)
--- a/Civi/Test/CiviEnvBuilder.php
+++ b/Civi/Test/CiviEnvBuilder.php
@@ -28,7 +28,7 @@ class CiviEnvBuilder {
    */
   private $targetSignature = NULL;
 
-  public function __construct($name) {
+  public function __construct(string $name = 'CiviEnvBuilder') {
     $this->name = $name;
   }