[NFC] code cleanup

Declare Exceptions, use strict, use single quotes

diff --git a/CRM/Member/Form/Task.php b/CRM/Member/Form/Task.php
index 72c9e23374d36417d9e0ccdf7f4d94a69ad4575f..04a02b8f245abd4a7df59f445e1a6871ab5cc7cb 100644 (file)
--- a/CRM/Member/Form/Task.php
+++ b/CRM/Member/Form/Task.php
@@ -13,8 +13,6 @@
  *
  * @package CRM
  * @copyright CiviCRM LLC https://civicrm.org/licensing
- * $Id$
- *
  */
 
 /**
@@ -36,6 +34,7 @@ class CRM_Member_Form_Task extends CRM_Core_Form_Task {
    * @param
    *
    * @return void
+   * @throws \CRM_Core_Exception
    */
   public function preProcess() {
     self::preProcessCommon($this);
@@ -43,6 +42,8 @@ class CRM_Member_Form_Task extends CRM_Core_Form_Task {
 
   /**
    * @param CRM_Core_Form $form
+   *
+   * @throws \CRM_Core_Exception
    */
   public static function preProcessCommon(&$form) {
     $form->_memberIds = [];
@@ -57,7 +58,7 @@ class CRM_Member_Form_Task extends CRM_Core_Form_Task {
     $form->assign('taskName', $tasks[$form->_task]);
 
     $ids = [];
-    if ($values['radio_ts'] == 'ts_sel') {
+    if ($values['radio_ts'] === 'ts_sel') {
       foreach ($values as $name => $value) {
         if (substr($name, 0, CRM_Core_Form::CB_PREFIX_LEN) == CRM_Core_Form::CB_PREFIX) {
           $ids[] = substr($name, CRM_Core_Form::CB_PREFIX_LEN);
@@ -99,7 +100,7 @@ class CRM_Member_Form_Task extends CRM_Core_Form_Task {
     }
 
     $searchFormName = strtolower($form->get('searchFormName'));
-    if ($searchFormName == 'search') {
+    if ($searchFormName === 'search') {
       $session->replaceUserContext(CRM_Utils_System::url('civicrm/member/search', $urlParams));
     }
     else {