*/
protected $_relationshipValuesAdded = FALSE;
- public $_pseudoConstantsSelect = array();
+ /**
+ * Set to the name of the temp table if one has been created
+ * @var String
+ */
+ static $_relationshipTempTable = NULL;
+ public $_pseudoConstantsSelect = array();
+
/**
* class constructor which also does all the work
*
case 'relation_start_date_low':
case 'relation_end_date_high':
case 'relation_end_date_low':
- $this->relationship($values);
- $this->_relationshipValuesAdded = TRUE;
- return;
-
case 'relation_target_name':
case 'relation_status':
case 'relation_date_low':
case 'relation_date_high':
- // since this case is handled with the above
+ $this->relationship($values);
+ $this->_relationshipValuesAdded = TRUE;
return;
case 'task_status_id':
$this->includeContactIds();
if (!empty($this->_params)) {
-
foreach (array_keys($this->_params) as $id) {
if (!CRM_Utils_Array::value(0, $this->_params[$id])) {
continue;
case 'civicrm_relationship':
if (self::$_relType == 'reciprocal') {
- $from .= " $side JOIN civicrm_relationship ON (civicrm_relationship.contact_id_b = contact_a.id OR civicrm_relationship.contact_id_a = contact_a.id)";
- $from .= " $side JOIN civicrm_contact contact_b ON (civicrm_relationship.contact_id_a = contact_b.id OR civicrm_relationship.contact_id_b = contact_b.id)";
+ if(self::$_relationshipTempTable) {
+ // we have a temptable to join on
+ $tbl = self::$_relationshipTempTable;
+ $from .= " INNER JOIN {$tbl} civicrm_relationship ON civicrm_relationship.contact_id = contact_a.id";
+ }
+ else {
+ $from .= " $side JOIN civicrm_relationship ON (civicrm_relationship.contact_id_b = contact_a.id OR civicrm_relationship.contact_id_a = contact_a.id)";
+ $from .= " $side JOIN civicrm_contact contact_b ON (civicrm_relationship.contact_id_a = contact_b.id OR civicrm_relationship.contact_id_b = contact_b.id)";
+ }
}
elseif (self::$_relType == 'b') {
$from .= " $side JOIN civicrm_relationship ON (civicrm_relationship.contact_id_b = contact_a.id )";
$rTypeValues = array();
$rType = CRM_Contact_BAO_RelationshipType::retrieve($params, $rTypeValues);
if ($rTypeValues['name_a_b'] == $rTypeValues['name_b_a']) {
+ // if we don't know which end of the relationship we are dealing with we'll create a temp table
+ //@todo unless we are dealing with a target group
self::$_relType = 'reciprocal';
}
-
- if ($nameClause) {
- $this->_where[$grouping][] = "( contact_b.sort_name $nameClause AND contact_b.id != contact_a.id )";
+ // if we are creating a temp table we build our own where for the relationship table
+ if(self::$_relType == 'reciprocal' && empty($targetGroup)) {
+ $where = array();
+ self::$_relationshipTempTable = $relationshipTempTable = 'civicrm_temp_rel' . rand(0,99999);
+ if($nameClause) {
+ $where[$grouping][] = " sort_name $nameClause ";
+ }
+ }
+ else {
+ $where = &$this->_where;
+ if ($nameClause) {
+ $where[$grouping][] = "( contact_b.sort_name $nameClause AND contact_b.id != contact_a.id )";
+ }
}
+
$relTypeInd = CRM_Contact_BAO_Relationship::getContactRelationshipType(NULL, 'null', NULL, 'Individual');
$relTypeOrg = CRM_Contact_BAO_Relationship::getContactRelationshipType(NULL, 'null', NULL, 'Organization');
$relTypeHou = CRM_Contact_BAO_Relationship::getContactRelationshipType(NULL, 'null', NULL, 'Household');
$today = date('Ymd');
//check for active, inactive and all relation status
if ($relStatus[2] == 0) {
- $this->_where[$grouping][] = "(
+ $where[$grouping][] = "(
civicrm_relationship.is_active = 1 AND
( civicrm_relationship.end_date IS NULL OR civicrm_relationship.end_date >= {$today} ) AND
( civicrm_relationship.start_date IS NULL OR civicrm_relationship.start_date <= {$today} )
$this->_qill[$grouping][] = ts('Relationship - Active and Current');
}
elseif ($relStatus[2] == 1) {
- $this->_where[$grouping][] = "(
+ $where[$grouping][] = "(
civicrm_relationship.is_active = 0 OR
civicrm_relationship.end_date < {$today} OR
civicrm_relationship.start_date > {$today}
$this->_qill[$grouping][] = ts('Relationship - Inactive or not Current');
}
- $this->addRelationshipDateClauses($grouping);
+ $this->addRelationshipDateClauses($grouping, $where);
if(!empty($rType) && isset($rType->id)){
- $this->_where[$grouping][] = 'civicrm_relationship.relationship_type_id = ' . $rType->id;
+ $where[$grouping][] = 'civicrm_relationship.relationship_type_id = ' . $rType->id;
}
$this->_tables['civicrm_relationship'] = $this->_whereTables['civicrm_relationship'] = 1;
$this->_useDistinct = TRUE;
$this->_relationshipValuesAdded = TRUE;
+ // it could be a or b, using an OR creates an unindexed join - better to create a temp table &
+ // join on that,
+ // @todo creating a temp table could be expanded to group filter
+ // as even creating a temp table of all relationships is much much more efficient than
+ // an OR in the join
+ if($relationshipTempTable) {
+ $whereClause = ' WHERE ' . implode(' AND ', $where[$grouping]);
+ $sql = "
+ CREATE TEMPORARY TABLE {$relationshipTempTable}
+ (SELECT contact_id_b as contact_id, civicrm_relationship.id
+ FROM civicrm_relationship
+ INNER JOIN civicrm_contact c ON civicrm_relationship.contact_id_a = c.id
+ $whereClause )
+ UNION
+ (SELECT contact_id_a as contact_id, civicrm_relationship.id
+ FROM civicrm_relationship
+ INNER JOIN civicrm_contact c ON civicrm_relationship.contact_id_b = c.id
+ $whereClause )
+ ";
+ CRM_Core_DAO::executeQuery($sql);
+ }
+
}
/**
* Add start & end date criteria in
* @param string $grouping
+ * @param array $where = array to add where clauses to, in case you are generating a temp table
+ * not the main query.
*/
- function addRelationshipDateClauses($grouping){
+ function addRelationshipDateClauses($grouping, &$where){
$dateValues = array();
$dateTypes = array(
'start_date',
$dateValueHigh= $this->getWhereValues('relation_'. $dateField .'_high', $grouping);
if(!empty($dateValueLow)){
$date = date('Ymd', strtotime($dateValueLow[2]));
- $this->_where[$grouping][] = "civicrm_relationship.$dateField >= $date";
+ $where[$grouping][] = "civicrm_relationship.$dateField >= $date";
$this->_qill[$grouping][] = ($dateField == 'end_date' ? ts('Relationship Ended on or After') : ts('Relationship Recorded Start Date On or Before')) . " " . CRM_Utils_Date::customFormat($date);
}
if(!empty($dateValueHigh)){
$date = date('Ymd', strtotime($dateValueHigh[2]));
- $this->_where[$grouping][] = "civicrm_relationship.$dateField <= $date";
+ $where[$grouping][] = "civicrm_relationship.$dateField <= $date";
$this->_qill[$grouping][] = ( $dateField == 'end_date' ? ts('Relationship Ended on or Before') : ts('Relationship Recorded Start Date On or After')) . " " . CRM_Utils_Date::customFormat($date);
}
}
projects / civicrm-core.git / commitdiff