Shift to Single Value Query as suggested by Eileen
authorSeamus Lee <seamuslee001@gmail.com>
Tue, 26 Jul 2016 05:21:46 +0000 (15:21 +1000)
committerSeamus Lee <seamuslee001@gmail.com>
Tue, 26 Jul 2016 05:21:46 +0000 (15:21 +1000)
CRM/Contribute/Form/Task/PDF.php

index e2396905217e31aa512d79f4e0f223bdbd2aa9d4..eea606e7556893149f7879d46be7c6fafa647420 100644 (file)
@@ -182,14 +182,11 @@ AND    {$this->_componentClause}";
       $input['trxn_date'] = isset($contribution->trxn_date) ? $contribution->trxn_date : NULL;
       $input['receipt_update'] = $params['receipt_update'];
       $input['contribution_status_id'] = $contribution->contribution_status_id;
-      $payment_processor_id = NULL;
-      $processorDAO = CRM_Core_DAO::executeQuery("SELECT payment_processor_id
+      $payment_processor_id = CRM_Core_DAO::singleValueQuery("SELECT payment_processor_id
         FROM civicrm_financial_trxn
-        WHERE trxn_id = %1", array(
+        WHERE trxn_id = %1
+        LIMIT 1", array(
           1 => array($contribution->trxn_id, 'String')));
-      while ($processorDAO->fetch()) {
-        $payment_processor_id = $processorDAO->payment_processor_id;
-      }
       $input['paymentProcessor'] = $payment_processor_id;
 
       // CRM_Contribute_BAO_Contribution::composeMessageArray expects mysql formatted date