Remove enclosed variable.

Given that it can only ever be a double quote parameterizing it is only confusing

diff --git a/CRM/Core/Report/Excel.php b/CRM/Core/Report/Excel.php
index 127f23e5c41eec47be4ad55d2b823d661f86c5fc..b4b3affb7c048292dd78de9b10cb00fd1c9eb5c3 100644 (file)
--- a/CRM/Core/Report/Excel.php
+++ b/CRM/Core/Report/Excel.php
@@ -40,13 +40,11 @@ class CRM_Core_Report_Excel {
 
     $config = CRM_Core_Config::singleton();
     $seperator = $config->fieldSeparator;
-    $enclosed = '"';
-    $escaped = $enclosed;
     $add_character = "\015\012";
 
     $schema_insert = '';
     foreach ($header as $field) {
-      $schema_insert .= $enclosed . str_replace($enclosed, $escaped . $enclosed, stripslashes($field)) . $enclosed;
+      $schema_insert .= '"' . str_replace('"', '""', stripslashes($field)) . '"';
       $schema_insert .= $seperator;
     }
     // end while
@@ -87,7 +85,7 @@ class CRM_Core_Report_Excel {
             $value = &$str;
           }
 
-          $schema_insert .= $enclosed . str_replace($enclosed, $escaped . $enclosed, $value) . $enclosed;
+          $schema_insert .= '"' . str_replace('"', '""', $value) . '"';
         }
 
         if ($colNo < $fields_cnt - 1) {