[REF] Pass params not-by-reference
authoreileen <emcnaughton@wikimedia.org>
Tue, 26 May 2020 03:50:04 +0000 (15:50 +1200)
committereileen <emcnaughton@wikimedia.org>
Tue, 26 May 2020 21:31:26 +0000 (09:31 +1200)
This is only called by one place in core + a deprecated unused class. The details are not used again

CRM/Activity/BAO/Activity.php

index 4a43aade74b4305c56aff965ffb774bc6f0ec346..20d2f0e072fc2972af0bbc4bedaf931af61adf5d 100644 (file)
@@ -1079,10 +1079,10 @@ class CRM_Activity_BAO_Activity extends CRM_Activity_DAO_Activity {
    * @throws \CiviCRM_API3_Exception
    */
   public static function sendEmail(
-    &$contactDetails,
-    &$subject,
-    &$text,
-    &$html,
+    $contactDetails,
+    $subject,
+    $text,
+    $html,
     $emailAddress,
     $userID = NULL,
     $from = NULL,