allow is_active field to default to '0'

diff --git a/Civi/Api4/Service/Spec/SpecGatherer.php b/Civi/Api4/Service/Spec/SpecGatherer.php
index 0e5225723dfe1dcf9b345156d48f0abb60db1565..d77e3a8bc49b226c77432a9c91da0697b1492901 100644 (file)
--- a/Civi/Api4/Service/Spec/SpecGatherer.php
+++ b/Civi/Api4/Service/Spec/SpecGatherer.php
@@ -97,9 +97,6 @@ class SpecGatherer extends AutoService {
       if (!empty($DAOField['component']) && !\CRM_Core_Component::isEnabled($DAOField['component'])) {
         continue;
       }
-      if ($DAOField['name'] == 'is_active' && empty($DAOField['default'])) {
-        $DAOField['default'] = '1';
-      }
       $this->setDynamicFk($DAOField, $values);
       $field = SpecFormatter::arrayToField($DAOField, $entityName);
       $spec->addFieldSpec($field);

diff --git a/tests/phpunit/api/v4/Spec/SpecGathererTest.php b/tests/phpunit/api/v4/Spec/SpecGathererTest.php
index 04de1c46a4f59a4f1886ebfb77d95999e6277687..f879af8c18c0d013fccae095fea1483c678bd965 100644 (file)
--- a/tests/phpunit/api/v4/Spec/SpecGathererTest.php
+++ b/tests/phpunit/api/v4/Spec/SpecGathererTest.php
@@ -65,4 +65,11 @@ class SpecGathererTest extends Api4TestBase {
     $this->assertContains('foo', $fieldNames);
   }
 
+  public function testIsActiveFieldCanDefaultToFalse(): void {
+    $gatherer = new SpecGatherer();
+    // Use Dashboard as it has is_active field and that defaults to 0 (according to schema)
+    $specs = $gatherer->getSpec('Dashboard', 'create', FALSE);
+    self::assertFalse($specs->getFieldByName('is_active')->getDefaultValue(), 'Default value for "is_active" field is not false');
+  }
+
 }