Fix warnings (#21)

* fix warnings

* remove warning hack

diff --git a/commandline/usbrelay-cmd.c b/commandline/usbrelay-cmd.c
index 4667f58837475ebaf2b6f12403d86205679b48d3..7245f708fa6685b135681fe4bb5eab212c08f47a 100644 (file)
--- a/commandline/usbrelay-cmd.c
+++ b/commandline/usbrelay-cmd.c
@@ -81,8 +81,6 @@ static int enumFunc(USBDEVHANDLE dev, void *context)
     int num = 0;
     int i;
 
-       (context); // ~ unreferenced warning
-
     err = usbhidGetVendorString(dev, buffer, sizeof(buffer));
     if ( err || 0 != strcmp( buffer, vendorName) )
     {

diff --git a/lib/usb_relay_lib.c b/lib/usb_relay_lib.c
index b0298237088bec82c1f357b6762b78e8b9745a00..87584606f907b0d9065313b81d5db14d4872d903 100644 (file)
--- a/lib/usb_relay_lib.c
+++ b/lib/usb_relay_lib.c
@@ -203,7 +203,7 @@ int enumfunc(USBDEVHANDLE usbh, void *context)
     int err;
     char buffer[128*sizeof(short)]; // max USB string is 128 UTF-16 chars
     int num = 0;
-    int i;
+    size_t i;
     struct usbrelay_internal_s *q;
     struct enumctx_s *ectx = (struct enumctx_s *)context;
 
@@ -215,7 +215,7 @@ int enumfunc(USBDEVHANDLE usbh, void *context)
         goto next;
     }
 
-    i = (int)strlen(buffer);
+    i = strlen(buffer);
     if ( i != strlen(productName) + 1 )
     {
         goto next;
@@ -301,7 +301,7 @@ int enumOpenfunc(USBDEVHANDLE usbh, void *context)
     int err;
     char buffer[128*sizeof(short)]; // max USB string is 128 UTF-16 chars
     int num = 0;
-    int i;
+    size_t i;
     struct enumctx_s *ectx = (struct enumctx_s *)context;
     struct usbrelay_internal_s *q = ectx->head;
 

diff --git a/qt/QUsbRelayGui/widget.cpp b/qt/QUsbRelayGui/widget.cpp
index 9df9606efe1684f3b934f0a5566ba96d8a580cec..bfdf7c1a63ecf08d0b70fc14331cd862d1dd38ab 100644 (file)
--- a/qt/QUsbRelayGui/widget.cpp
+++ b/qt/QUsbRelayGui/widget.cpp
@@ -9,7 +9,7 @@ Widget::Widget(QWidget *parent) :
 
     list.searchForDevices();
 
-    for(auto i=0; i< list.m_devices.size();i++){
+    for(size_t i=0; i<list.m_devices.size(); i++){
 
         getRelayStatus(i);