dev/core#627 Extend a unit test to verify fix made by Sunil

Add in additional test for when no transactions have occured

diff --git a/tests/phpunit/CRM/Pledge/BAO/PledgePaymentTest.php b/tests/phpunit/CRM/Pledge/BAO/PledgePaymentTest.php
index c02ed2497791cc11bc590adaf51b260890f0de88..fcc0d3a2ba394b0da8fef31fa07f4db14d803120 100644 (file)
--- a/tests/phpunit/CRM/Pledge/BAO/PledgePaymentTest.php
+++ b/tests/phpunit/CRM/Pledge/BAO/PledgePaymentTest.php
@@ -527,6 +527,8 @@ class CRM_Pledge_BAO_PledgePaymentTest extends CiviUnitTestCase {
       $this->assertEquals(1, $pp['status_id']);
     }
 
+    $this->assertEquals(count($pledgePayments['values']), CRM_Pledge_BAO_Pledge::pledgeHasFinancialTransactions($pledge->id, 2));
+
     // Cleanup
     civicrm_api3('Pledge', 'delete', array(
       'id' => $pledge->id,

diff --git a/tests/phpunit/CRM/Pledge/BAO/PledgeTest.php b/tests/phpunit/CRM/Pledge/BAO/PledgeTest.php
index 76e2b29fcd9af2f78189b56c8afd0014e7d6b8ab..b29ccbce3d1db72b215a9c67a18506213b1ab54c 100644 (file)
--- a/tests/phpunit/CRM/Pledge/BAO/PledgeTest.php
+++ b/tests/phpunit/CRM/Pledge/BAO/PledgeTest.php
@@ -91,6 +91,8 @@ class CRM_Pledge_BAO_PledgeTest extends CiviUnitTestCase {
 
     $this->assertEquals(count($pledgePayment), 1);
     $payment = array_pop($pledgePayment);
+    // Assert that we actually have no pledge Payments
+    $this->assertEquals(0, CRM_Pledge_BAO_Pledge::pledgeHasFinancialTransactions($pledge->id, array_search('Pending', CRM_Contribute_PseudoConstant::contributionStatus(NULL, 'name'))));
     $this->assertEquals($payment['status'], 'Pending');
     $this->assertEquals($payment['scheduled_date'], date('Y-m-d 00:00:00', strtotime($scheduledDate)));
   }