Remove hardcode value

diff --git a/CRM/Member/BAO/Membership.php b/CRM/Member/BAO/Membership.php
index 18a142a8a2c8d5b06de6c26389a984c5575ccc3d..ecce3a4a82bd2edb9b1490f739c1ae8ef239d567 100644 (file)
--- a/CRM/Member/BAO/Membership.php
+++ b/CRM/Member/BAO/Membership.php
@@ -2305,7 +2305,8 @@ INNER JOIN  civicrm_contact contact ON ( contact.id = membership.contact_id AND
    */
   public static function createOrRenewMembership($membershipParams, $contactID, $customFieldsFormatted, $membershipID, $memType, $isTest, $numTerms, $membershipContribution, &$form) {
     if (!empty($membershipContribution)) {
-      $pending = ($membershipContribution->contribution_status_id == 2) ? TRUE : FALSE;
+      $pendingStatus = CRM_Core_OptionGroup::getValue('contribution_status', 'Pending', 'name');
+      $pending = ($membershipContribution->contribution_status_id == $pendingStatus) ? TRUE : FALSE;
     }
     $membership = self::renewMembershipFormWrapper($contactID, $memType,
       $isTest, $form, NULL,