Merge pull request #22886 from demeritcowboy/contributionview-notice3

Simplify fix for smarty/php notice on contributionview

diff --cc CRM/Contribute/Form/ContributionView.php
index 694674525244cdcb2b2bc021529bc50c7a9a81ec,bdf3c50cc130139aecfe8e601afacb921f46fc8f..a223724bb6a0d12f1db04adddce9547f3bc176eb
--- 1/CRM/Contribute/Form/ContributionView.php
--- 2/CRM/Contribute/Form/ContributionView.php
+++ b/CRM/Contribute/Form/ContributionView.php
@@@ -44,13 -44,10 +44,11 @@@ class CRM_Contribute_Form_ContributionV
      $values = (array) $contribution;
      $contributionStatus = CRM_Core_PseudoConstant::getName('CRM_Contribute_BAO_Contribution', 'contribution_status_id', $values['contribution_status_id']);
  
-     if (!isset($this->get_template_vars()['hookDiscount'])) {
-       $this->assign('hookDiscount', ['message' => '']);
-     }
      $this->addExpectedSmartyVariables([
+       'hookDiscount',
        'pricesetFieldsCount',
        'pcp_id',
 +      'getTaxDetails',
        // currencySymbol maybe doesn't make sense but is probably old?
        'currencySymbol',
      ]);