Merge pull request #18393 from eileenmcnaughton/just_load

Remove error handling from loadObjects

diff --cc CRM/Contribute/BAO/Contribution.php
Simple merge

diff --cc tests/phpunit/CRM/Core/Payment/BaseIPNTest.php
index d2d777f9faf3e7fe2177043e85d17fc67519b653,f56f11cf56b9e3b4f023c2b71241ef13c99455d1..4b4da2c8de1a5cf4c9bc578385155c0181114c5b
--- 1/tests/phpunit/CRM/Core/Payment/BaseIPNTest.php
--- 2/tests/phpunit/CRM/Core/Payment/BaseIPNTest.php
+++ b/tests/phpunit/CRM/Core/Payment/BaseIPNTest.php
@@@ -145,11 -145,11 +145,11 @@@ class CRM_Core_Payment_BaseIPNTest exte
      $contribution->find(TRUE);
      $contribution->loadRelatedObjects($this->input, $this->ids, TRUE);
      $this->assertNotEmpty($contribution->_relatedObjects['membership']);
 -    $this->assertArrayHasKey($this->_membershipTypeID, $contribution->_relatedObjects['membership']);
 -    $this->assertTrue(is_a($contribution->_relatedObjects['membership'][$this->_membershipTypeID], 'CRM_Member_BAO_Membership'));
 +    $this->assertArrayHasKey($this->_membershipId . '_' . $this->_membershipTypeID, $contribution->_relatedObjects['membership']);
 +    $this->assertTrue(is_a($contribution->_relatedObjects['membership'][$this->_membershipId . '_' . $this->_membershipTypeID], 'CRM_Member_BAO_Membership'));
      $this->assertTrue(is_a($contribution->_relatedObjects['financialType'], 'CRM_Financial_BAO_FinancialType'));
-     $this->assertFalse(empty($contribution->_relatedObjects['contributionRecur']));
-     $this->assertFalse(empty($contribution->_relatedObjects['paymentProcessor']));
+     $this->assertNotEmpty($contribution->_relatedObjects['contributionRecur']);
+     $this->assertNotEmpty($contribution->_relatedObjects['paymentProcessor']);
    }
  
    /**