CRM-19293: Dashboard options disappear after CiviContribute Component Settings save

----------------------------------------
* CRM-19293: Dashboard options disappear after CiviContribute Component Settings save
  https://issues.civicrm.org/jira/browse/CRM-19293

diff --git a/CRM/Admin/Form/Preferences/Contribute.php b/CRM/Admin/Form/Preferences/Contribute.php
index d8a10303884ebe725b00f28d7811ff9c63b95171..caa0c55365c8292cf6567dbe0266fe681d4c06e8 100644 (file)
--- a/CRM/Admin/Form/Preferences/Contribute.php
+++ b/CRM/Admin/Form/Preferences/Contribute.php
@@ -248,7 +248,7 @@ class CRM_Admin_Form_Preferences_Contribute extends CRM_Admin_Form_Preferences {
     else {
       $setting = explode(CRM_Core_DAO::VALUE_SEPARATOR, substr($values['user_dashboard_options'], 1, -1));
       $invoiceKey = array_search($setKey, $setting);
-      if (!empty($invoiceKey)) {
+      if ($invoiceKey !== FALSE) {
         unset($setting[$invoiceKey]);
       }
       $settingName = CRM_Core_DAO::VALUE_SEPARATOR .