Minor code cleanup - remove unnecessary ids declaration
authoreileen <emcnaughton@wikimedia.org>
Fri, 15 Mar 2019 21:31:50 +0000 (10:31 +1300)
committereileen <emcnaughton@wikimedia.org>
Fri, 15 Mar 2019 21:31:50 +0000 (10:31 +1300)
 is not used  is only used to set ['id'] so this can be simplified

CRM/Event/Form/Registration/Confirm.php

index 8557a30dec308af240a958a044975f43092c9569..5034b1fb069c7c4195acf28bca262edf833b9266 100644 (file)
@@ -1017,21 +1017,14 @@ class CRM_Event_Form_Registration_Confirm extends CRM_Event_Form_Registration {
       $contribParams['is_test'] = 1;
     }
 
-    $contribID = NULL;
     if (!empty($contribParams['invoice_id'])) {
-      $contribID = CRM_Core_DAO::getFieldValue('CRM_Contribute_DAO_Contribution',
+      $contribParams['id'] = CRM_Core_DAO::getFieldValue('CRM_Contribute_DAO_Contribution',
         $contribParams['invoice_id'],
         'id',
         'invoice_id'
       );
     }
 
-    $ids = array();
-    if ($contribID) {
-      $ids['contribution'] = $contribID;
-      $contribParams['id'] = $contribID;
-    }
-
     if (CRM_Contribute_BAO_Contribution::checkContributeSettings('deferred_revenue_enabled')) {
       $eventStartDate = CRM_Utils_Array::value(
         'start_date',