projects
/
civicrm-core.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
d42a0ae
)
Remove pass-by-ref in PaypalProIPN::single
author
eileen
<emcnaughton@wikimedia.org>
Thu, 3 Sep 2020 04:18:36 +0000
(16:18 +1200)
committer
eileen
<emcnaughton@wikimedia.org>
Thu, 3 Sep 2020 04:18:36 +0000
(16:18 +1200)
This is called from 2 places. Neither use the values again & neither receive any pass-by-reference values
themselves
CRM/Core/Payment/PayPalProIPN.php
patch
|
blob
|
blame
|
history
diff --git
a/CRM/Core/Payment/PayPalProIPN.php
b/CRM/Core/Payment/PayPalProIPN.php
index e5c58d3de7ec8045dbb6e4187fd822b114853a43..024d845b427ae3b15db26653d2794f5baf253105 100644
(file)
--- a/
CRM/Core/Payment/PayPalProIPN.php
+++ b/
CRM/Core/Payment/PayPalProIPN.php
@@
-321,7
+321,7
@@
class CRM_Core_Payment_PayPalProIPN extends CRM_Core_Payment_BaseIPN {
*
* @return void
*/
- public function single(
&$input, &$ids, &
$objects, $recur = FALSE, $first = FALSE) {
+ public function single(
$input, $ids,
$objects, $recur = FALSE, $first = FALSE) {
$contribution = &$objects['contribution'];
// make sure the invoice is valid and matches what we have in the contribution record