Remove unused variables from repeatTransaction
authorMatthew Wire <mjw@mjwconsult.co.uk>
Thu, 20 Aug 2020 20:38:03 +0000 (21:38 +0100)
committerMatthew Wire <mjw@mjwconsult.co.uk>
Thu, 20 Aug 2020 20:38:50 +0000 (21:38 +0100)
CRM/Contribute/BAO/Contribution.php

index 496d64dcda22e27a98927a4553f851efba859a22..35bd4f13266852cf8369c7b7425b74b5ca61be72 100644 (file)
@@ -2613,7 +2613,7 @@ LEFT JOIN  civicrm_contribution contribution ON ( componentPayment.contribution_
    * @return bool|array
    * @throws CiviCRM_API3_Exception
    */
-  protected static function repeatTransaction(&$contribution, &$input, $contributionParams) {
+  protected static function repeatTransaction(&$contribution, $input, $contributionParams) {
     if (!empty($contribution->id)) {
       return FALSE;
     }
@@ -4498,7 +4498,7 @@ INNER JOIN civicrm_activity ON civicrm_activity_contact.activity_id = civicrm_ac
     ], array_intersect_key($input, array_fill_keys($inputContributionWhiteList, 1)
     ));
 
-    $contributionParams['payment_processor'] = $input['payment_processor'] = $paymentProcessorId;
+    $contributionParams['payment_processor'] = $paymentProcessorId;
 
     // If paymentProcessor is not set then the payment_instrument_id would not be correct.
     // not clear when or if this would occur if you encounter this please fix here & add a unit test.