(dev/core#183) Change temp table naming for CRM_Activity_BAO_Activity
authorTim Otten <totten@civicrm.org>
Fri, 15 Jun 2018 03:35:05 +0000 (20:35 -0700)
committerTim Otten <totten@civicrm.org>
Fri, 15 Jun 2018 03:35:05 +0000 (20:35 -0700)
Note: Verified that changes to this line are reflected as passes/failures in
CRM_Activity_BAO_ActivityTest.

CRM/Activity/BAO/Activity.php

index 11fcfa530d619db4bcfaaf5906248e7a28a5e3c8..31c3c253d9328b511a0c761210ddcf5ea3791400 100644 (file)
@@ -920,8 +920,7 @@ class CRM_Activity_BAO_Activity extends CRM_Activity_DAO_Activity {
 
     $config = CRM_Core_Config::singleton();
 
-    $randomNum = md5(uniqid());
-    $activityTempTable = "civicrm_temp_activity_details_{$randomNum}";
+    $activityTempTable = CRM_Utils_SQL_TempTable::build()->setCategory('actdetail')->getName();
 
     $tableFields = array(
       'activity_id' => 'int unsigned',
@@ -1012,7 +1011,7 @@ LEFT JOIN  civicrm_case_activity ON ( civicrm_case_activity.activity_id = tbl.ac
 
     // step 2: Get target and assignee contacts for above activities
     // create temp table for target contacts
-    $activityContactTempTable = "civicrm_temp_activity_contact_{$randomNum}";
+    $activityContactTempTable = CRM_Utils_SQL_TempTable::build()->setCategory('actcontact')->getName();
     $query = "CREATE TEMPORARY TABLE {$activityContactTempTable} (
                 activity_id int unsigned, contact_id int unsigned, record_type_id varchar(16),
                  contact_name varchar(255), is_deleted int unsigned, counter int unsigned, INDEX index_activity_id( activity_id ) )