[REF] Remove unused variables
authoreileen <emcnaughton@wikimedia.org>
Mon, 22 Feb 2021 03:10:30 +0000 (16:10 +1300)
committereileen <emcnaughton@wikimedia.org>
Mon, 22 Feb 2021 03:10:30 +0000 (16:10 +1300)
existingAmount is never used except in this if so cannot be true. feeTotal
is used above this point but not below it - so this code is extraneous

templates/CRM/Member/Form/Membership.tpl

index 3498abf6a0920884bca9ef1179f553a8ab429615..7de2f3b7c6a5191dc4580a1910aff56080b65fa5 100644 (file)
       function setPaymentBlock(mode, checkboxEvent) {
         var memType = parseInt(cj('#membership_type_id_1').val( ));
         var isPriceSet = 0;
-        var existingAmount = 0;
 
         if ( cj('#price_set_id').length > 0 && cj('#price_set_id').val() ) {
           isPriceSet = 1;
             var feeTotal = parseFloat(Number((taxRate/100) * allMemberships[memType]['total_amount'])+Number(allMemberships[memType]['total_amount_numeric'])).toFixed(2);
             cj("#total_amount").val(CRM.formatMoney(feeTotal, true));
           }
-          else {
-            var feeTotal = allMemberships[memType]['total_amount'];
-            if (!existingAmount) {
-              // CRM-16680 don't set amount if there is an existing contribution.
-              cj("#total_amount").val(allMemberships[memType]['total_amount']);
-            }
-          }
         }
         var taxMessage = taxRate!=undefined ? 'Includes '+taxTerm+' amount of '+currency+' '+taxAmount:'';
         cj('.totaltaxAmount').html(taxMessage);