INFRA-132 - Squiz.Scope.MethodScope.Missing

diff --git a/CRM/Activity/Import/Parser.php b/CRM/Activity/Import/Parser.php
index 1ee8ad52305da28f3c1cd9a195a1e93f0d683015..fa89d48ba41cc457df6dacb7cdc4e42f590efded 100644 (file)
--- a/CRM/Activity/Import/Parser.php
+++ b/CRM/Activity/Import/Parser.php
@@ -73,7 +73,7 @@ abstract class CRM_Activity_Import_Parser extends CRM_Import_Parser {
    * @return mixed
    * @throws Exception
    */
-  function run(
+  public function run(
     $fileName,
     $seperator = ',',
     &$mapper,

diff --git a/CRM/Activity/Selector/Search.php b/CRM/Activity/Selector/Search.php
index 4810718dbb0e048b751cffc049d9da8f30005cd0..296c51f37e074653027ef958278ed3c92f9a1615 100644 (file)
--- a/CRM/Activity/Selector/Search.php
+++ b/CRM/Activity/Selector/Search.php
@@ -153,7 +153,7 @@ class CRM_Activity_Selector_Search extends CRM_Core_Selector_Base implements CRM
    *
    * @return \CRM_Activity_Selector_Search
    */
-  function __construct(
+  public function __construct(
     &$queryParams,
     $action = CRM_Core_Action::NONE,
     $activityClause = NULL,

diff --git a/CRM/Admin/Page/Persistent.php b/CRM/Admin/Page/Persistent.php
index c9081233c382f0cbc372de0f5c2fbf9e3980ffce..7df058b9deb8ee0ff39140c3d8f89f5432667c40 100644 (file)
--- a/CRM/Admin/Page/Persistent.php
+++ b/CRM/Admin/Page/Persistent.php
@@ -52,7 +52,7 @@ class CRM_Admin_Page_Persistent extends CRM_Core_Page {
    * @return array
    *   (reference) of action links
    */
-  function &stringActionLinks() {
+  public function &stringActionLinks() {
     // check if variable _actionsLinks is populated
     if (!isset(self::$_stringActionLinks)) {
 

diff --git a/CRM/Contact/BAO/Group.php b/CRM/Contact/BAO/Group.php
index a62c2bd822558039720976a9c54ba38eeb6e242e..25549003ff6889fae3f4050615f312b1e4bdb898 100644 (file)
--- a/CRM/Contact/BAO/Group.php
+++ b/CRM/Contact/BAO/Group.php
@@ -238,7 +238,7 @@ class CRM_Contact_BAO_Group extends CRM_Contact_DAO_Group {
    * @todo other BAO functions that use returnProperties (e.g. Query Objects) receive the array flipped & filled with 1s and
    * add in essential fields (e.g. id). This should follow a regular pattern like the others
    */
-  static function getGroups(
+  public static function getGroups(
     $params = NULL,
     $returnProperties = NULL,
     $sort = NULL,
@@ -994,7 +994,7 @@ class CRM_Contact_BAO_Group extends CRM_Contact_DAO_Group {
    *
    * @return array
    */
-  static function getGroupsHierarchy(
+  public static function getGroupsHierarchy(
     $groupIDs,
     $parents = NULL,
     $spacer = '<span class="child-indent"></span>',

diff --git a/CRM/Contact/Form/Search/Custom/ContributionAggregate.php b/CRM/Contact/Form/Search/Custom/ContributionAggregate.php
index 8a9545ca7eb75dc293b3fb373cd596a2b05fe32b..3eb41d1179c7688df372a0a63d45ca60c12df62b 100644 (file)
--- a/CRM/Contact/Form/Search/Custom/ContributionAggregate.php
+++ b/CRM/Contact/Form/Search/Custom/ContributionAggregate.php
@@ -115,7 +115,7 @@ class CRM_Contact_Form_Search_Custom_ContributionAggregate implements CRM_Contac
    *
    * @return string
    */
-  function all(
+  public function all(
     $offset = 0, $rowcount = 0, $sort = NULL,
     $includeContactIDs = FALSE, $justIDs = FALSE
   ) {

diff --git a/CRM/Contact/Form/Search/Custom/TagContributions.php b/CRM/Contact/Form/Search/Custom/TagContributions.php
index f0347c084f51dd2f5873f35c23ae53ffed3287c5..d580312bdf44a79f8dab5b6a057d35197f549f08 100644 (file)
--- a/CRM/Contact/Form/Search/Custom/TagContributions.php
+++ b/CRM/Contact/Form/Search/Custom/TagContributions.php
@@ -93,7 +93,7 @@ class CRM_Contact_Form_Search_Custom_TagContributions implements CRM_Contact_For
   /**
    * Construct the search query
    */
-  function all(
+  public function all(
     $offset = 0, $rowcount = 0, $sort = NULL,
     $includeContactIDs = FALSE, $onlyIDs = FALSE
   ) {

diff --git a/CRM/Contribute/Form/Contribution/Confirm.php b/CRM/Contribute/Form/Contribution/Confirm.php
index 62334a81039528115bbf5d23769da9d07e9458eb..78711ba826575bc801ea276291544042abdb82d7 100644 (file)
--- a/CRM/Contribute/Form/Contribution/Confirm.php
+++ b/CRM/Contribute/Form/Contribution/Confirm.php
@@ -1229,7 +1229,7 @@ class CRM_Contribute_Form_Contribution_Confirm extends CRM_Contribute_Form_Contr
    * @throws Exception
    * @return CRM_Contribute_DAO_Contribution
    */
-  static function processContribution(
+  public static function processContribution(
     &$form,
     $params,
     $result,

diff --git a/CRM/Core/BAO/CustomField.php b/CRM/Core/BAO/CustomField.php
index 2f94a658fd9559c5cc6cbd85cb50a4e4c6d654f5..2f5806ca5b37a94f7fc5592134128b73dd3c2af9 100644 (file)
--- a/CRM/Core/BAO/CustomField.php
+++ b/CRM/Core/BAO/CustomField.php
@@ -1153,7 +1153,7 @@ class CRM_Core_BAO_CustomField extends CRM_Core_DAO_CustomField {
    *
    * @return array|mixed|null|string
    */
-  static function getDisplayValueCommon(
+  public static function getDisplayValueCommon(
     $value,
     &$option,
     $html_type,
@@ -1366,7 +1366,7 @@ class CRM_Core_BAO_CustomField extends CRM_Core_DAO_CustomField {
    *                               just format the given value
    *
    */
-  static function setProfileDefaults(
+  public static function setProfileDefaults(
     $customFieldId,
     $elementName,
     &$defaults,
@@ -1580,7 +1580,7 @@ class CRM_Core_BAO_CustomField extends CRM_Core_DAO_CustomField {
    * @return array
    *   formatted custom field array
    */
-  static function formatCustomField(
+  public static function formatCustomField(
     $customFieldId, &$customFormatted, $value,
     $customFieldExtend, $customValueId = NULL,
     $entityId = NULL,
@@ -2238,7 +2238,7 @@ ORDER BY html_type";
    *
    * @return array
    */
-  static function postProcess(
+  public static function postProcess(
     &$params,
     &$customFields,
     $entityID,

diff --git a/CRM/Core/BAO/Setting.php b/CRM/Core/BAO/Setting.php
index 46678a4ffbc61a2381ff9be2850b15964bf6dc7a..250e1e1aaf72e38516ae6d20ab1e3f22d576234d 100644 (file)
--- a/CRM/Core/BAO/Setting.php
+++ b/CRM/Core/BAO/Setting.php
@@ -82,7 +82,7 @@ class CRM_Core_BAO_Setting extends CRM_Core_DAO_Setting {
    * @return boolean
    *   true if item is already in cache
    */
-  static function inCache(
+  public static function inCache(
     $group,
     $name,
     $componentID = NULL,
@@ -133,7 +133,7 @@ class CRM_Core_BAO_Setting extends CRM_Core_DAO_Setting {
    *
    * @return string
    */
-  static function setCache(
+  public static function setCache(
     $values,
     $group,
     $componentID = NULL,
@@ -163,7 +163,7 @@ class CRM_Core_BAO_Setting extends CRM_Core_DAO_Setting {
    *
    * @return CRM_Core_DAO_Domain|CRM_Core_DAO_Setting
    */
-  static function dao(
+  public static function dao(
     $group,
     $name = NULL,
     $componentID = NULL,
@@ -219,7 +219,7 @@ class CRM_Core_BAO_Setting extends CRM_Core_DAO_Setting {
    * @return mixed
    *   The data if present in the setting table, else null
    */
-  static function getItem(
+  public static function getItem(
     $group,
     $name = NULL,
     $componentID = NULL,
@@ -346,7 +346,7 @@ class CRM_Core_BAO_Setting extends CRM_Core_DAO_Setting {
    *
    * @return void
    */
-  static function setItem(
+  public static function setItem(
     $value,
     $group,
     $name,
@@ -380,7 +380,7 @@ class CRM_Core_BAO_Setting extends CRM_Core_DAO_Setting {
    * @param int $createdID
    * @param int $domainID
    */
-  static function _setItem(
+  public static function _setItem(
     $metadata,
     $value,
     $group,
@@ -646,7 +646,7 @@ class CRM_Core_BAO_Setting extends CRM_Core_DAO_Setting {
    * - description
    * - help_text
    */
-  static function getSettingSpecification(
+  public static function getSettingSpecification(
     $componentID = NULL,
     $filters = array(),
     $domainID = NULL,
@@ -832,7 +832,7 @@ class CRM_Core_BAO_Setting extends CRM_Core_DAO_Setting {
    *
    * @return array
    */
-  static function valueOptions(
+  public static function valueOptions(
     $group,
     $name,
     $system = TRUE,
@@ -891,7 +891,7 @@ class CRM_Core_BAO_Setting extends CRM_Core_DAO_Setting {
    * @param int $userID
    * @param string $keyField
    */
-  static function setValueOption(
+  public static function setValueOption(
     $group,
     $name,
     $value,

diff --git a/CRM/Core/BAO/Tag.php b/CRM/Core/BAO/Tag.php
index 296aad1e356cc91434cd3cdad1cd86b8cae7f257..68f3b316f25cc8a54a9b9b445e0ed72fa80c3c53 100644 (file)
--- a/CRM/Core/BAO/Tag.php
+++ b/CRM/Core/BAO/Tag.php
@@ -197,7 +197,7 @@ class CRM_Core_BAO_Tag extends CRM_Core_DAO_Tag {
    *
    * @return array
    */
-  static function getTags(
+  public static function getTags(
     $usedFor = 'civicrm_contact',
     &$tags = array(),
     $parentId = NULL,

diff --git a/CRM/Core/Form.php b/CRM/Core/Form.php
index 09f6c9299d0478c8874e9dc29b73d38100e0ae2e..9aee8a8933c2bca8a0eb97b1d05e75ea16ccdf90 100644 (file)
--- a/CRM/Core/Form.php
+++ b/CRM/Core/Form.php
@@ -167,7 +167,7 @@ class CRM_Core_Form extends HTML_QuickForm_Page {
    *
    * @return \CRM_Core_Form
    */
-  function __construct(
+  public function __construct(
     $state = NULL,
     $action = CRM_Core_Action::NONE,
     $method = 'post',
@@ -267,7 +267,7 @@ class CRM_Core_Form extends HTML_QuickForm_Page {
    *
    * @return HTML_QuickForm_Element could be an error object
    */
-  function &add(
+  public function &add(
     $type, $name, $label = '',
     $attributes = '', $required = FALSE, $extra = NULL
   ) {
@@ -918,7 +918,7 @@ class CRM_Core_Form extends HTML_QuickForm_Page {
    * @param string $separator
    * @param bool $flipValues
    */
-  function addCheckBox(
+  public function addCheckBox(
     $id, $title, $values, $other = NULL,
     $attributes = NULL, $required = NULL,
     $javascriptMethod = NULL,
@@ -1387,7 +1387,7 @@ class CRM_Core_Form extends HTML_QuickForm_Page {
   /**
    * Add a currency and money element to the form
    */
-  function addMoney(
+  public function addMoney(
     $name,
     $label,
     $required = FALSE,
@@ -1410,7 +1410,7 @@ class CRM_Core_Form extends HTML_QuickForm_Page {
   /**
    * Add currency element to the form
    */
-  function addCurrency(
+  public function addCurrency(
     $name = 'currency',
     $label = NULL,
     $required = TRUE,

diff --git a/CRM/Core/OptionGroup.php b/CRM/Core/OptionGroup.php
index 46d6ce541f1b41b0cc9860a91b2020b2974cd4dd..b43c2fe6a2dabdbf3f343a200319da1fa742b8ca 100644 (file)
--- a/CRM/Core/OptionGroup.php
+++ b/CRM/Core/OptionGroup.php
@@ -54,7 +54,7 @@ class CRM_Core_OptionGroup {
    *
    * @return array
    */
-  static function &valuesCommon(
+  public static function &valuesCommon(
     $dao, $flip = FALSE, $grouping = FALSE,
     $localize = FALSE, $valueColumnName = 'label'
   ) {
@@ -115,7 +115,7 @@ class CRM_Core_OptionGroup {
    *   the values as specified by the above params
    * @void
    */
-  static function &values(
+  public static function &values(
     $name, $flip = FALSE, $grouping = FALSE,
     $localize = FALSE, $condition = NULL,
     $labelColumnName = 'label', $onlyActive = TRUE, $fresh = FALSE, $keyColumnName = 'value'
@@ -374,7 +374,7 @@ WHERE  v.option_group_id = g.id
    *
    * @return null
    */
-  static function getValue(
+  public static function getValue(
     $groupName,
     $label,
     $labelField = 'label',
@@ -594,7 +594,7 @@ SELECT v.label
    *
    * @return array
    */
-  static function getRowValues(
+  public static function getRowValues(
     $groupName, $fieldValue, $field = 'name',
     $fieldType = 'String', $active = TRUE
   ) {

diff --git a/CRM/Custom/Form/CustomData.php b/CRM/Custom/Form/CustomData.php
index 844229ac8ba9c3d624dff50951326d4955688b42..da4e9661fc74afb3299a7c2255f2cfaa4d4157e3 100644 (file)
--- a/CRM/Custom/Form/CustomData.php
+++ b/CRM/Custom/Form/CustomData.php
@@ -49,7 +49,7 @@ class CRM_Custom_Form_CustomData {
    *
    * @return void
    */
-  static function preProcess(
+  public static function preProcess(
     &$form, $subName = NULL, $subType = NULL,
     $groupCount = NULL, $type = NULL, $entityID = NULL, $onlySubType = NULL
   ) {

diff --git a/CRM/Event/BAO/Participant.php b/CRM/Event/BAO/Participant.php
index 6a7097e4edf5b166adc43840610f2c03a075cb34..c4464a21bfea36ebe471b77846f8c74c412db371 100644 (file)
--- a/CRM/Event/BAO/Participant.php
+++ b/CRM/Event/BAO/Participant.php
@@ -352,7 +352,7 @@ class CRM_Event_BAO_Participant extends CRM_Event_DAO_Participant {
    * @return bool|int|null|string
    *   1. false                 => If event having some empty spaces.
    */
-  static function eventFull(
+  public static function eventFull(
     $eventId,
     $returnEmptySeats = FALSE,
     $includeWaitingList = TRUE,
@@ -496,7 +496,7 @@ SELECT  event.event_full_text,
    * @return array
    *   an array of each option id and total count
    */
-  static function priceSetOptionsCount(
+  public static function priceSetOptionsCount(
     $eventId,
     $skipParticipantIds = array(),
     $considerCounted = TRUE,
@@ -1225,7 +1225,7 @@ UPDATE  civicrm_participant
    *
    * @return array
    */
-  static function transitionParticipants(
+  public static function transitionParticipants(
     $participantIds, $toStatusId,
     $fromStatusId = NULL, $returnResult = FALSE, $skipCascadeRule = FALSE
   ) {
@@ -1461,7 +1461,7 @@ UPDATE  civicrm_participant
    *
    * @return bool
    */
-  static function sendTransitionParticipantMail(
+  public static function sendTransitionParticipantMail(
     $participantId,
     $participantValues,
     $eventDetails,

diff --git a/CRM/Event/Selector/Search.php b/CRM/Event/Selector/Search.php
index 60552f195809a74817b295a54a22200b5876c2a5..a983983642b4b407854461a4b2d0d2d5f475c180 100644 (file)
--- a/CRM/Event/Selector/Search.php
+++ b/CRM/Event/Selector/Search.php
@@ -157,7 +157,7 @@ class CRM_Event_Selector_Search extends CRM_Core_Selector_Base implements CRM_Co
    *
    * @return \CRM_Event_Selector_Search
    */
-  function __construct(
+  public function __construct(
     &$queryParams,
     $action = CRM_Core_Action::NONE,
     $eventClause = NULL,

diff --git a/CRM/Mailing/BAO/Query.php b/CRM/Mailing/BAO/Query.php
index 0bb8498e2dcdde330791165ebf21a89ba59b14c8..174a829ae6b8d404d0830562a853de89bcb2d5fd 100644 (file)
--- a/CRM/Mailing/BAO/Query.php
+++ b/CRM/Mailing/BAO/Query.php
@@ -197,7 +197,7 @@ class CRM_Mailing_BAO_Query {
    *
    * @return array|null
    */
-  static function defaultReturnProperties(
+  public static function defaultReturnProperties(
     $mode,
     $includeCustomFields = TRUE
   ) {

diff --git a/CRM/Mailing/Selector/Search.php b/CRM/Mailing/Selector/Search.php
index 13d152ece0c86408856c2c034dc2df49e9a49081..f50f13c1cad552f689f7dfe170e283f02345f581 100644 (file)
--- a/CRM/Mailing/Selector/Search.php
+++ b/CRM/Mailing/Selector/Search.php
@@ -147,7 +147,7 @@ class CRM_Mailing_Selector_Search extends CRM_Core_Selector_Base implements CRM_
    *
    * @return \CRM_Mailing_Selector_Search
    */
-  function __construct(
+  public function __construct(
     &$queryParams,
     $action = CRM_Core_Action::NONE,
     $mailingClause = NULL,

diff --git a/CRM/Price/Page/Option.php b/CRM/Price/Page/Option.php
index 5a7ac0cdf0f6885da971f1f62aafd740650baa19..ba380113832d10fe0b88e4117efe54e75da98b0b 100644 (file)
--- a/CRM/Price/Page/Option.php
+++ b/CRM/Price/Page/Option.php
@@ -81,7 +81,7 @@ class CRM_Price_Page_Option extends CRM_Core_Page {
    * @return array
    *   array of action links that we need to display for the browse screen
    */
-  function &actionLinks() {
+  public function &actionLinks() {
     if (!isset(self::$_actionLinks)) {
       self::$_actionLinks = array(
         CRM_Core_Action::UPDATE => array(

diff --git a/CRM/SMS/Provider.php b/CRM/SMS/Provider.php
index 34e41db57c4c269ee6fdcc56d8cab0e859000add..f374f904bec55751459a0db51c6f046b0c117174 100644 (file)
--- a/CRM/SMS/Provider.php
+++ b/CRM/SMS/Provider.php
@@ -89,7 +89,7 @@ abstract class CRM_SMS_Provider {
   /**
    * Send an SMS Message via the API Server
    */
-  abstract function send($recipients, $header, $message, $dncID = NULL);
+  abstract public function send($recipients, $header, $message, $dncID = NULL);
 
   /**
    * Return message text. Child class could override this function to have better control over the message being sent.

diff --git a/CRM/Utils/Hook/DrupalBase.php b/CRM/Utils/Hook/DrupalBase.php
index 21dca9dee63f7443c18b140302e8ac5d78d1d664..02ef926108f5268eb7b244673fbb0369ddff1eab 100644 (file)
--- a/CRM/Utils/Hook/DrupalBase.php
+++ b/CRM/Utils/Hook/DrupalBase.php
@@ -75,7 +75,7 @@ class CRM_Utils_Hook_DrupalBase extends CRM_Utils_Hook {
    *
    * @return array|bool
    */
-  function invoke(
+  public function invoke(
     $numParams,
     &$arg1, &$arg2, &$arg3, &$arg4, &$arg5, &$arg6,
     $fnSuffix) {

diff --git a/tests/phpunit/CRM/Core/BAO/ActionScheduleTest.php b/tests/phpunit/CRM/Core/BAO/ActionScheduleTest.php
index bcf4a5db8178be88305bc158ecadef05075ef124..1439e6f19638492a0ea8e82f6e0e358dc7192f02 100644 (file)
--- a/tests/phpunit/CRM/Core/BAO/ActionScheduleTest.php
+++ b/tests/phpunit/CRM/Core/BAO/ActionScheduleTest.php
@@ -945,7 +945,7 @@ class CRM_Core_BAO_ActionScheduleTest extends CiviUnitTestCase {
    *
    * @return array|NULL|object
    */
-  function createTestObject($daoName, $params = array(), $numObjects = 1, $createOnly = FALSE) {
+  public function createTestObject($daoName, $params = array(), $numObjects = 1, $createOnly = FALSE) {
     $objects = CRM_Core_DAO::createTestObject($daoName, $params, $numObjects, $createOnly);
     if (is_array($objects)) {
       $this->registerTestObjects($objects);

diff --git a/tests/phpunit/WebTest/Event/MultiprofileEventTest.php b/tests/phpunit/WebTest/Event/MultiprofileEventTest.php
index c4563b09d7e4ddb7d217d895395a79ba4f50f4f5..191747681bb99f0dc3797f8b78aeaa7d0502c1ac 100644 (file)
--- a/tests/phpunit/WebTest/Event/MultiprofileEventTest.php
+++ b/tests/phpunit/WebTest/Event/MultiprofileEventTest.php
@@ -642,7 +642,7 @@ class WebTest_Event_MultiprofileEventTest extends CiviSeleniumTestCase {
    * @param $email1
    * @param $email2
    */
-  function _testEventRegistration(
+  public function _testEventRegistration(
     $eventPageId, $customId, $firstName, $lastName,
     $participantfname, $participantlname, $email1, $email2
   ) {

diff --git a/tests/phpunit/api/v3/ContributionTest.php b/tests/phpunit/api/v3/ContributionTest.php
index b926430dded8a2c1ffe34f55bb293563b534b54e..b6dafb75b0bc3109304b7fb947d9e9bc2f281af8 100644 (file)
--- a/tests/phpunit/api/v3/ContributionTest.php
+++ b/tests/phpunit/api/v3/ContributionTest.php
@@ -1620,7 +1620,7 @@ class api_v3_ContributionTest extends CiviUnitTestCase {
    *
    * @return null|string
    */
-  function _getFinancialTrxnAmount($contId) {
+  public function _getFinancialTrxnAmount($contId) {
     $query = "SELECT
      SUM( ft.total_amount ) AS total
      FROM civicrm_financial_trxn AS ft
@@ -1637,7 +1637,7 @@ class api_v3_ContributionTest extends CiviUnitTestCase {
    *
    * @return null|string
    */
-  function _getFinancialItemAmount($contId) {
+  public function _getFinancialItemAmount($contId) {
     $lineItem = key(CRM_Price_BAO_LineItem::getLineItems($contId, 'contribution'));
     $query = "SELECT
      SUM(amount)