[REF] dev/core#4418 Add in Unit test of submitting the form to ensure no double handl...

Remove deprecation notice as per coleman

Minor fixes to match the form better

diff --git a/CRM/Financial/BAO/PaymentProcessor.php b/CRM/Financial/BAO/PaymentProcessor.php
index 4a316ef1478ec2ab5e5375914a952ac620798533..b46df53a76dbda1dd464adfa9b086da3d1a56e46 100644 (file)
--- a/CRM/Financial/BAO/PaymentProcessor.php
+++ b/CRM/Financial/BAO/PaymentProcessor.php
@@ -79,7 +79,6 @@ class CRM_Financial_BAO_PaymentProcessor extends CRM_Financial_DAO_PaymentProces
    * @return self|null
    */
   public static function retrieve($params, &$defaults) {
-    CRM_Core_Error::deprecatedFunctionWarning('API');
     return self::commonRetrieve(self::class, $params, $defaults);
   }
 

diff --git a/tests/phpunit/CRM/Admin/Form/PaymentProcessorTest.php b/tests/phpunit/CRM/Admin/Form/PaymentProcessorTest.php
new file mode 100644 (file)
index 0000000..b4e4c17
--- /dev/null
+++ b/tests/phpunit/CRM/Admin/Form/PaymentProcessorTest.php
@@ -0,0 +1,40 @@
+<?php
+
+use Civi\APi4\PaymentProcessor;
+
+/**
+ * @group headless
+ */
+class CRM_Admin_Form_PaymentProcessorTest extends CiviUnitTestCase {
+
+  use CRM_Core_Payment_AuthorizeNetTrait;
+
+  /**
+   * Test that saving accept credit card field doesn't double json encode.
+   *
+   * @throws \CRM_Core_Exception
+   */
+  public function testUpdateAcceptCreditCard(): void {
+    $this->createAuthorizeNetProcessor();
+    $this->paymentProcessorAuthorizeNetCreate();
+    $_REQUEST['id'] = $this->ids['PaymentProcessor']['anet'];
+    $form = new CRM_Admin_Form_PaymentProcessor(NULL, CRM_Core_Action::UPDATE);
+    $form->controller = new CRM_Core_Controller();
+    $pageName = $form->getName();
+    $form->controller->setStateMachine(new CRM_Core_StateMachine($form->controller));
+    $form->preProcess();
+    $paymentProcessor = $this->callAPISuccess('PaymentProcessor', 'getSingle', ['id' => $form->_id]);
+    $form->updatePaymentProcessor(array_merge($paymentProcessor, [
+      'accept_credit_cards' => [
+        'Visa' => 1,
+        'MasterCard' => 1,
+      ],
+      'financial_account_id' => CRM_Financial_BAO_PaymentProcessor::getDefaultFinancialAccountID(),
+    ]), 1, 0);
+    $this->assertEquals([
+      'Visa' => 'Visa',
+      'MasterCard' => 'MasterCard',
+    ], PaymentProcessor::get()->addWhere('id', '=', $form->_id)->execute()->first()['accepted_credit_cards']);
+  }
+
+}