Fix fatal error regression in master
authoreileen <emcnaughton@wikimedia.org>
Thu, 11 Jun 2020 23:17:06 +0000 (11:17 +1200)
committereileen <emcnaughton@wikimedia.org>
Thu, 11 Jun 2020 23:17:06 +0000 (11:17 +1200)
Fatal from this line due to pass by reference

https://github.com/civicrm/civicrm-core/pull/16514/files#diff-a8611c9a226a40b585001082b38467b0R207

CRM/Contribute/Form/UpdateBilling.php

index 8c8454547f07ac3786c280af47d2c83485e3f24a..9a1b1a939464cb7748b178ece0161b8acfa56836 100644 (file)
@@ -204,7 +204,8 @@ class CRM_Contribute_Form_UpdateBilling extends CRM_Contribute_Form_Contribution
     $processorParams['year'] = CRM_Core_Payment_Form::getCreditCardExpirationYear($processorParams);
     $processorParams['subscriptionId'] = $this->getSubscriptionDetails()->processor_id;
     $processorParams['amount'] = $this->_subscriptionDetails->amount;
-    $updateSubscription = $this->_paymentProcessor['object']->updateSubscriptionBillingInfo('', $processorParams);
+    $message = '';
+    $updateSubscription = $this->_paymentProcessor['object']->updateSubscriptionBillingInfo($message, $processorParams);
     if (is_a($updateSubscription, 'CRM_Core_Error')) {
       CRM_Core_Error::displaySessionError($updateSubscription);
     }