CRM-16643 - Add 'setvalue' deprecation warning to api explorer

diff --git a/api/v3/examples/Contact/GetActions.php b/api/v3/examples/Contact/GetActions.php
index f12c3fac94c81cbd28c1d8acd7d3ac0cc95f59f0..12012f6949561078daff496d4ebf1d5f543b0717 100644 (file)
--- a/api/v3/examples/Contact/GetActions.php
+++ b/api/v3/examples/Contact/GetActions.php
@@ -67,6 +67,7 @@ function contact_getactions_expectedresult() {
     ),
     'deprecated' => array(
       'getquick' => 'The "getquick" action is deprecated in favor of "getlist".',
+      'setvalue' => 'The "setvalue" action is deprecated. Use "create" with an id instead.',
       'update' => 'The "update" action is deprecated. Use "create" with an id instead.',
     ),
   );

diff --git a/api/v3/utils.php b/api/v3/utils.php
index 4aa999795d9de21ac4a12c7e3bddf21ad43ab234..cab2d4cc31b5d6aca38110ab7af6791e716fc9a6 100644 (file)
--- a/api/v3/utils.php
+++ b/api/v3/utils.php
@@ -263,6 +263,10 @@ function civicrm_api3_create_success($values = 1, $params = array(), $entity = N
   }
   // Report deprecations.
   $deprecated = _civicrm_api3_deprecation_check($entity, $result);
+  // The "setvalue" action is deprecated but still in use, so report it only on "getactions".
+  if (!is_string($deprecated) && $action == 'getactions') {
+    $deprecated = ((array) $deprecated) + array('setvalue' => 'The "setvalue" action is deprecated. Use "create" with an id instead.');
+  }
   // Always report "update" action as deprecated.
   if (!is_string($deprecated) && ($action == 'getactions' || $action == 'update')) {
     $deprecated = ((array) $deprecated) + array('update' => 'The "update" action is deprecated. Use "create" with an id instead.');