[PHP8.2] Remove undefined property in favour of calc-as-needed

This appears to be one of those cases where they wanted to
'save the code the effort' of calculating twice - but
it is a trivial calculation balanced
against the confusion of setting an undefined
property in one place to use later

diff --git a/CRM/Contribute/Form/Contribution/Main.php b/CRM/Contribute/Form/Contribution/Main.php
index f5ff70097d92d303ac4db2be22874cd0072b91ef..0e48c3926954f15dbb60fa4c8a06191f98d46904 100644 (file)
--- a/CRM/Contribute/Form/Contribution/Main.php
+++ b/CRM/Contribute/Form/Contribution/Main.php
@@ -1201,7 +1201,7 @@ class CRM_Contribute_Form_Contribution_Main extends CRM_Contribute_Form_Contribu
     }
 
     if (!empty($this->_ccid)) {
-      $this->set('lineItem', $this->_lineItem);
+      $this->set('lineItem', [$this->getPriceSetID() => $this->getExistingContributionLineItems()]);
     }
     elseif ($priceSetId = CRM_Utils_Array::value('priceSetId', $params)) {
       $lineItem = [];
@@ -1383,8 +1383,6 @@ class CRM_Contribute_Form_Contribution_Main extends CRM_Contribute_Form_Contribu
     }
 
     $lineItems = $this->getExistingContributionLineItems();
-    // Is this used?
-    $this->_lineItem[$this->getPriceSetID()] = $lineItems;
     $this->assign('lineItem', [$this->getPriceSetID() => $lineItems]);
     $this->assign('is_quick_config', $this->isQuickConfig());
     $this->assign('priceSetID', $this->getPriceSetID());