Test cleanup fix
authoreileen <emcnaughton@wikimedia.org>
Sat, 26 Sep 2020 00:23:33 +0000 (12:23 +1200)
committereileen <emcnaughton@wikimedia.org>
Sat, 26 Sep 2020 00:23:33 +0000 (12:23 +1200)
Note it's better practice to clean up in the tear down but it looks like someone
tried & failed before so let's see....

tests/phpunit/api/v3/JobProcessMailingTest.php

index 23153c40e4ec684cd54c51db4fea60dffca191b5..71d18540772e086214903b309041eaf58bb387a2 100644 (file)
@@ -42,7 +42,6 @@ class api_v3_JobProcessMailingTest extends CiviUnitTestCase {
   private $_mut;
 
   public function setUp() {
-    $this->cleanupMailingTest();
     parent::setUp();
     // DGW
     CRM_Mailing_BAO_MailingJob::$mailsProcessed = 0;
@@ -83,13 +82,10 @@ class api_v3_JobProcessMailingTest extends CiviUnitTestCase {
   /**
    */
   public function tearDown() {
-    //$this->_mut->clearMessages();
     $this->_mut->stop();
     CRM_Utils_Hook::singleton()->reset();
-    $this->quickCleanup(['civicrm_activity_contact', 'civicrm_activity']);
-    // DGW
+    $this->cleanupMailingTest();
     CRM_Mailing_BAO_MailingJob::$mailsProcessed = 0;
-    //$this->cleanupMailingTest();
     parent::tearDown();
   }
 
@@ -572,6 +568,8 @@ class api_v3_JobProcessMailingTest extends CiviUnitTestCase {
       'civicrm_group',
       'civicrm_group_contact',
       'civicrm_contact',
+      'civicrm_activity_contact',
+      'civicrm_activity',
     ]);
   }