Test regression fix

diff --git a/CRM/Contribute/Form/Contribution.php b/CRM/Contribute/Form/Contribution.php
index 9526d6bb7d4a68f498f9a656a21f7af7a8362386..ba9b781b33c58141979daaa0c85b896338bd3db6 100644 (file)
--- a/CRM/Contribute/Form/Contribution.php
+++ b/CRM/Contribute/Form/Contribution.php
@@ -1840,11 +1840,14 @@ class CRM_Contribute_Form_Contribution extends CRM_Contribute_Form_AbstractEditP
   /**
    * Get the selected contribution status.
    *
-   * @return string
+   * @return string|null
    *
    * @throws \API_Exception
    */
-  protected function getPreviousContributionStatus(): string {
+  protected function getPreviousContributionStatus(): ?string {
+    if (!$this->getContributionID()) {
+      return NULL;
+    }
     if (!$this->previousContributionStatus) {
       $this->previousContributionStatus = Contribution::get(FALSE)
         ->addWhere('id', '=', $this->getContributionID())

diff --git a/tests/phpunit/CRM/Contribute/Form/ContributionTest.php b/tests/phpunit/CRM/Contribute/Form/ContributionTest.php
index 9bf1e03523d6b1427a9e3e654485419369fd8479..e7788fb61f0f4674be34076bb09961f91e98a36e 100644 (file)
--- a/tests/phpunit/CRM/Contribute/Form/ContributionTest.php
+++ b/tests/phpunit/CRM/Contribute/Form/ContributionTest.php
@@ -144,9 +144,6 @@ class CRM_Contribute_Form_ContributionTest extends CiviUnitTestCase {
    *
    * @param string $thousandSeparator
    *
-   * @throws \CRM_Core_Exception
-   * @throws \CiviCRM_API3_Exception
-   * @throws \Civi\Payment\Exception\PaymentProcessorException
    * @dataProvider getThousandSeparators
    */
   public function testSubmit(string $thousandSeparator): void {