Remove never-true-if

This code is in the recur() function. the lines immediately before this function ensure contribution->contribution_status_id
is unset if it is 1 - meaning this if can never be true

diff --git a/CRM/Core/Payment/AuthorizeNetIPN.php b/CRM/Core/Payment/AuthorizeNetIPN.php
index c278ced641b8326d240148ce66b3d524a9d806d7..72eae6f88226e5397f09d8af272dde9abdd9b9c5 100644 (file)
--- a/CRM/Core/Payment/AuthorizeNetIPN.php
+++ b/CRM/Core/Payment/AuthorizeNetIPN.php
@@ -158,13 +158,6 @@ class CRM_Core_Payment_AuthorizeNetIPN extends CRM_Core_Payment_BaseIPN {
       return FALSE;
     }
 
-    // check if contribution is already completed, if so we ignore this ipn
-    if ($contribution->contribution_status_id == 1) {
-      CRM_Core_Error::debug_log_message("Returning since contribution has already been handled.");
-      echo 'Success: Contribution has already been handled<p>';
-      return FALSE;
-    }
-
     CRM_Contribute_BAO_Contribution::completeOrder($input, $recur->id, $contribution->id ?? NULL);
     return $isFirstOrLastRecurringPayment;
   }