Add is_active to link spec

In the process of adding weights to the links it
occurred to me that it might be cleaner in some cases for
hooks to fiddle with 'is_active' rather than setting &
unsetting.

An example would be that instead of excluding
a link that our core code thinks should not be available
we could include it with is_active = FALSE &
a hook could enable it.

I figured if it I add it now then while adding weights I could
bank it in too

diff --git a/CRM/Core/Action.php b/CRM/Core/Action.php
index c815704a2677b9650d03adf398bb47286884e629..d23bd256a455e9e3aacdd1699ecd0c4e32a5e599 100644 (file)
--- a/CRM/Core/Action.php
+++ b/CRM/Core/Action.php
@@ -222,7 +222,8 @@ class CRM_Core_Action {
     });
 
     foreach ($seqLinks as $i => $link) {
-      if (!$mask || !array_key_exists('bit', $link) || ($mask & $link['bit'])) {
+      $isActive = $link['is_active'] ?? TRUE;
+      if ($isActive && (!$mask || !array_key_exists('bit', $link) || ($mask & $link['bit']))) {
         $extra = isset($link['extra']) ? self::replace($link['extra'], $values) : NULL;
 
         $frontend = isset($link['fe']);
@@ -257,10 +258,10 @@ class CRM_Core_Action {
 
         $linkContent = $link['name'];
         if (!empty($link['icon'])) {
-          if ($iconMode == 'icon') {
+          if ($iconMode === 'icon') {
             $linkContent = CRM_Core_Page::crmIcon($link['icon'], $link['name'], TRUE, ['title' => '']);
           }
-          elseif ($iconMode == 'both') {
+          elseif ($iconMode === 'both') {
             $linkContent = CRM_Core_Page::crmIcon($link['icon']) . ' ' . $linkContent;
           }
         }
@@ -283,7 +284,7 @@ class CRM_Core_Action {
     }
     else {
       $extra = '';
-      if ($iconMode != 'icon') {
+      if ($iconMode !== 'icon') {
         $extraLinks = array_splice($url, 2);
         if (count($extraLinks) > 1) {
           $mainLinks = array_slice($url, 0, 2);