Updated video thumbnail pipeline to use decodebin2
authorayleph <ayleph@thisshitistemp.com>
Sat, 2 Aug 2014 03:15:55 +0000 (20:15 -0700)
committerayleph <ayleph@thisshitistemp.com>
Sat, 2 Aug 2014 03:15:55 +0000 (20:15 -0700)
The video thumbnailer uses decodebin to automatically detect the file type in the thumbnail pipeline. However, decodebin does not properly demux theora streams, which causes the thumbnailer to fail for .ogv files. decodebin2 properly demuxes the theora stream and successfully creates thumbnails for .ogv files.

mediagoblin/media_types/video/transcoders.py

index 9d6b765540ef8657dc9b5f9bc7ff86a23d3a967c..3a3fa97f6ecaaa6efd2a41a4654169f58e11ca06 100644 (file)
@@ -186,7 +186,7 @@ from playbin')
         self.buffer_probes = {}
 
         pipeline = ''.join([
-            'filesrc location="%s" ! decodebin ! ' % self.source_path,
+            'filesrc location="%s" ! decodebin2 ! ' % self.source_path,
             'ffmpegcolorspace ! videoscale ! ',
             'video/x-raw-rgb,depth=24,bpp=24,pixel-aspect-ratio=1/1',
             ',width={0}'.format(self.width) if self.width else '',