dev/core#2066 Use shared function to set the next url
authoreileen <emcnaughton@wikimedia.org>
Wed, 14 Oct 2020 19:55:57 +0000 (08:55 +1300)
committereileen <emcnaughton@wikimedia.org>
Wed, 14 Oct 2020 19:55:57 +0000 (08:55 +1300)
Extends https://github.com/civicrm/civicrm-core/pull/18767 to more places

CRM/Campaign/Form/Task.php
CRM/Event/Form/Task.php
CRM/Grant/Form/Task.php
CRM/Member/Form/Task.php
CRM/Pledge/Form/Task.php

index 61411931d0ad3017097b620e3bd4e50440334711..f5193017a287e7e83a90081e02ba91ccd04d90ff 100644 (file)
@@ -58,15 +58,7 @@ class CRM_Campaign_Form_Task extends CRM_Core_Form_Task {
     $this->_voterIds = $this->_contactIds = $this->_componentIds = $ids;
 
     $this->assign('totalSelectedContacts', count($this->_contactIds));
-
-    //set the context for redirection for any task actions
-    $session = CRM_Core_Session::singleton();
-    $qfKey = CRM_Utils_Request::retrieve('qfKey', 'String', $this);
-    $urlParams = 'force=1';
-    if (CRM_Utils_Rule::qfKey($qfKey)) {
-      $urlParams .= '&qfKey=' . $qfKey;
-    }
-    $session->replaceUserContext(CRM_Utils_System::url('civicrm/survey/search', $urlParams));
+    $this->setNextUrl('survey');
   }
 
   /**
index 4da684f51308070f10a006c0da301fd01bf75629..745fe3c06fa74cb3bf09a21b8f159f89bec6c86f 100644 (file)
@@ -86,24 +86,7 @@ class CRM_Event_Form_Task extends CRM_Core_Form_Task {
 
     $form->_participantIds = $form->_componentIds = $ids;
 
-    //set the context for redirection for any task actions
-    $session = CRM_Core_Session::singleton();
-
-    $qfKey = CRM_Utils_Request::retrieve('qfKey', 'String', $form);
-    $urlParams = 'force=1';
-    if (CRM_Utils_Rule::qfKey($qfKey)) {
-      $urlParams .= "&qfKey=$qfKey";
-    }
-
-    $searchFormName = strtolower($form->get('searchFormName'));
-    if ($searchFormName == 'search') {
-      $session->replaceUserContext(CRM_Utils_System::url('civicrm/event/search', $urlParams));
-    }
-    else {
-      $session->replaceUserContext(CRM_Utils_System::url("civicrm/contact/search/$searchFormName",
-        $urlParams
-      ));
-    }
+    $form->setNextUrl('event');
   }
 
   /**
index 893077cfb76462b69fec4d1f6f3b37cc6767b345..a5096f91603ad4aa5586394e7c115ddc5a780d6f 100644 (file)
@@ -81,15 +81,7 @@ class CRM_Grant_Form_Task extends CRM_Core_Form_Task {
 
     $form->_grantIds = $form->_componentIds = $ids;
 
-    //set the context for redirection for any task actions
-    $qfKey = CRM_Utils_Request::retrieve('qfKey', 'String', $form);
-    $urlParams = 'force=1';
-    if (CRM_Utils_Rule::qfKey($qfKey)) {
-      $urlParams .= "&qfKey=$qfKey";
-    }
-
-    $session = CRM_Core_Session::singleton();
-    $session->replaceUserContext(CRM_Utils_System::url('civicrm/grant/search', $urlParams));
+    $form->setNextUrl('grant');
   }
 
   /**
index 6718d6eaebf1562e55e69fca363a4ea8b58cf965..b2a6225c752d9be09ec57bfb248612ba709cc08b 100644 (file)
@@ -88,25 +88,7 @@ class CRM_Member_Form_Task extends CRM_Core_Form_Task {
     }
 
     $form->_memberIds = $form->_componentIds = $ids;
-
-    //set the context for redirection for any task actions
-    $session = CRM_Core_Session::singleton();
-
-    $qfKey = CRM_Utils_Request::retrieve('qfKey', 'String', $form);
-    $urlParams = 'force=1';
-    if (CRM_Utils_Rule::qfKey($qfKey)) {
-      $urlParams .= "&qfKey=$qfKey";
-    }
-
-    $searchFormName = strtolower($form->get('searchFormName'));
-    if ($searchFormName === 'search') {
-      $session->replaceUserContext(CRM_Utils_System::url('civicrm/member/search', $urlParams));
-    }
-    else {
-      $session->replaceUserContext(CRM_Utils_System::url("civicrm/contact/search/$searchFormName",
-        $urlParams
-      ));
-    }
+    $form->setNextUrl('member');
   }
 
   /**
index 12df902a9169ea1fbb03de84d507f3577b20a359..9de09f66667dc2b63fd691764d2231582aad0236 100644 (file)
@@ -38,7 +38,7 @@ class CRM_Pledge_Form_Task extends CRM_Core_Form_Task {
   /**
    * Common pre-processing.
    *
-   * @param CRM_Core_Form $form
+   * @param CRM_Pledge_Form_Task $form
    */
   public static function preProcessCommon(&$form) {
     $form->_pledgeIds = [];
@@ -79,16 +79,7 @@ class CRM_Pledge_Form_Task extends CRM_Core_Form_Task {
     }
 
     $form->_pledgeIds = $form->_componentIds = $ids;
-
-    // set the context for redirection for any task actions
-    $qfKey = CRM_Utils_Request::retrieve('qfKey', 'String', $form);
-    $urlParams = 'force=1';
-    if (CRM_Utils_Rule::qfKey($qfKey)) {
-      $urlParams .= "&qfKey=$qfKey";
-    }
-
-    $session = CRM_Core_Session::singleton();
-    $session->replaceUserContext(CRM_Utils_System::url('civicrm/pledge/search', $urlParams));
+    $form->setNextUrl('pledge');
   }
 
   /**