AngularLoader - Emit warning when setModules method is used.

It can cause conflicts with other extensions who have added modules.

diff --git a/Civi/Angular/AngularLoader.php b/Civi/Angular/AngularLoader.php
index a5d6d38b5774ecde81dc9da97fab8b942c750cbb..a6b5f80a42e8f3c40237a69ba3fc994f755be7cc 100644 (file)
--- a/Civi/Angular/AngularLoader.php
+++ b/Civi/Angular/AngularLoader.php
@@ -345,11 +345,13 @@ class AngularLoader {
    * Replace all previously set modules.
    *
    * Use with caution, as it can cause conflicts with other extensions who have added modules.
-   *
+   * @internal
+   * @deprecated
    * @param array $modules
    * @return AngularLoader
    */
   public function setModules($modules) {
+    \CRM_Core_Error::deprecatedFunctionWarning('addModules');
     $this->modules = $modules;
     return $this;
   }

diff --git a/tests/phpunit/Civi/Angular/LoaderTest.php b/tests/phpunit/Civi/Angular/LoaderTest.php
index d26e4d2e4ce04d10658d8a08ecc470f0bfcab84e..029daef6aa2b530e4198cc71a4b22675807331c8 100644 (file)
--- a/tests/phpunit/Civi/Angular/LoaderTest.php
+++ b/tests/phpunit/Civi/Angular/LoaderTest.php
@@ -47,9 +47,9 @@ class LoaderTest extends \CiviUnitTestCase {
    */
   public function testSettingFactory($module, $expectedSettingCount, $expectedCallbackCount, $expectedPermissions) {
     $loader = new \Civi\Angular\AngularLoader();
-    $loader->setModules([$module]);
+    $loader->addModules([$module]);
     $loader->useApp();
-    // Load triggers a depreaction notice, use @ to suppress it for the test.
+    // Load triggers a deprecation notice, use @ to suppress it for the test.
     @$loader->load();
 
     // Run factory callbacks