Change Activity tag to use select2
authorPradeep Nayak <pradpnayak@gmail.com>
Tue, 14 May 2019 23:08:47 +0000 (00:08 +0100)
committerPradeep Nayak <pradpnayak@gmail.com>
Tue, 14 May 2019 23:08:47 +0000 (00:08 +0100)
CRM/Activity/BAO/Query.php
templates/CRM/Activity/Form/Search/Common.tpl

index 8f7cd076b8f5f06e5981e4fdef8f39fee1982361..764f2537da4149120d7ee1bc55893c4eb467817f 100644 (file)
@@ -325,7 +325,6 @@ class CRM_Activity_BAO_Query {
         }
 
       case 'activity_tags':
-        $value = array_keys($value);
         $activityTags = CRM_Core_PseudoConstant::get('CRM_Core_DAO_EntityTag', 'tag_id', ['onlyActive' => FALSE]);
 
         $names = [];
@@ -527,11 +526,9 @@ class CRM_Activity_BAO_Query {
     $form->addYesNo('activity_test', ts('Activity is a Test?'));
     $activity_tags = CRM_Core_BAO_Tag::getTags('civicrm_activity');
     if ($activity_tags) {
-      foreach ($activity_tags as $tagID => $tagName) {
-        $form->_tagElement = &$form->addElement('checkbox', "activity_tags[$tagID]",
-          NULL, $tagName
-        );
-      }
+      $form->add('select', 'activity_tags', ts('Activity Tag(s)'), $activity_tags, FALSE,
+        ['id' => 'activity_tags', 'multiple' => 'multiple', 'class' => 'crm-select2']
+      );
     }
 
     $parentNames = CRM_Core_BAO_Tag::getTagSet('civicrm_activity');
index e9ac9139fa3ef882b4d372eb6faf2d3c6e931239..15f597a10159456e5d0f5e6997d20438f8cde4de 100644 (file)
       </td></tr>
     </table>
   </td>
-  {if $form.activity_tags}
-    <td><label>{ts}Activity Tag(s){/ts}</label>
-      <div id="Tags" class="listing-box">
-        {foreach from=$form.activity_tags item="tag_val"}
-          <div class="{cycle values='odd-row,even-row'}">
-            {$tag_val.html}
-          </div>
-        {/foreach}
-    </td>
-  {else}
-    <td>&nbsp;</td>
-  {/if}
 </tr>
 
+{if $form.activity_tags}
+  <tr>
+    <td><label>{$form.activity_tags.label}</label>
+      <br/>
+      {$form.activity_tags.html}
+    </td>
+  </tr>
+{/if}
+
 <tr>
   {include file="CRM/Core/DatePickerRangeWrapper.tpl" fieldName="activity_date_time" colspan="2"}
   <td>&nbsp;</td>