CRM-21360: Make 'Open Case' Activity Optional

Removed conditionals that made 'Open Case' activity on standard timeline
mandatory on Case Type create and edit views. Also added a label to default
Reference value so users can choose '-- Case Start --' as reference for
offsets.

diff --git a/ang/crmCaseType.js b/ang/crmCaseType.js
index 66ca2b1594d4d65cb19756230ac07fcde0f433f4..e3b4a16c6ab72518e0b9aab66a8d290458351a26 100644 (file)
--- a/ang/crmCaseType.js
+++ b/ang/crmCaseType.js
@@ -288,11 +288,7 @@
     };
 
     $scope.isActivityRemovable = function(activitySet, activity) {
-      if (activitySet.name == 'standard_timeline' && activity.name == 'Open Case') {
-        return false;
-      } else {
-        return true;
-      }
+      return true;
     };
 
     $scope.isValidName = function(name) {

diff --git a/ang/crmCaseType/timelineTable.html b/ang/crmCaseType/timelineTable.html
index 5014c79946eef31c80fbabc178e0259dd3fc0008..15a0f935b1cbe8eb40eeceb01b415eb84e1686fc 100644 (file)
--- a/ang/crmCaseType/timelineTable.html
+++ b/ang/crmCaseType/timelineTable.html
@@ -40,9 +40,9 @@ Required vars: activitySet
         ui-options="{dropdownAutoWidth : true}"
         ng-model="activity.reference_activity"
         ng-options="activityType.name as activityType.label for activityType in activitySet.activityTypes"
-        ng-hide="activity.name == 'Open Case'"
-        ng-required="activity.name != 'Open Case'"
+        ng-required="activity.name != ''"
         >
+        <option value="">-- Case Start --</option>
       </select>
     </td>
     <td>
@@ -51,8 +51,7 @@ Required vars: activitySet
         type="text"
         ng-pattern="/^-?[0-9]*$/"
         ng-model="activity.reference_offset"
-        ng-hide="activity.name == 'Open Case'"
-        ng-required="activity.name != 'Open Case'"
+        ng-required="activity.name != ''"
         >
     </td>
     <td>
@@ -61,8 +60,7 @@ Required vars: activitySet
         ui-options="{dropdownAutoWidth : true}"
         ng-model="activity.reference_select"
         ng-options="key as value for (key,value) in {newest: ts('Newest'), oldest: ts('Oldest')}"
-        ng-hide="activity.name == 'Open Case'"
-        ng-required="activity.name != 'Open Case'"
+        ng-required="activity.name != ''"
         >
       </select>
     </td>