CRM-15187, added checks for financial type and amount

----------------------------------------
* CRM-15187: Accounting implications of Membership Type changes
  https://issues.civicrm.org/jira/browse/CRM-15187

diff --git a/CRM/Member/Form/Membership.php b/CRM/Member/Form/Membership.php
index 2c7fb5a744a6e2a790055379154cac2e82ff9bfc..73f5a1b2ef31cda63731f49c8558917dbed29dbf 100644 (file)
--- a/CRM/Member/Form/Membership.php
+++ b/CRM/Member/Form/Membership.php
@@ -1832,14 +1832,22 @@ class CRM_Member_Form_Membership extends CRM_Member_Form {
     //CRM-15187
     // display message when membership type is changed
     if (($this->_action & CRM_Core_Action::UPDATE) && $this->_id && !in_array($this->_memType, $this->_memTypeSelected)) {
-      CRM_Core_Session::setStatus(
-        ts('The financial types associated with the old and new membership types are different. You may want to edit the contribution associated with this membership to adjust its financial type.'),
-        ts('Warning')
-      );
-      CRM_Core_Session::setStatus(
-        ts('The cost of the old and new membership types are different. You may want to edit the contribution associated with this membership to adjust its amount.'),
-        ts('Warning')
-      );
+      $lineItem = CRM_Price_BAO_LineItem::getLineItems($this->_id, 'membership');
+      $maxID = max(array_keys($lineItem));
+      $lineItem = $lineItem[$maxID];
+      $membershipTypeDetails = $this->allMembershipTypeDetails[$membership->membership_type_id];
+      if ($membershipTypeDetails['financial_type_id'] != $lineItem['financial_type_id']) {
+        CRM_Core_Session::setStatus(
+          ts('The financial types associated with the old and new membership types are different. You may want to edit the contribution associated with this membership to adjust its financial type.'),
+          ts('Warning')
+        );
+      }
+      if ($membershipTypeDetails['minimum_fee'] != $lineItem['line_total']) {
+        CRM_Core_Session::setStatus(
+          ts('The cost of the old and new membership types are different. You may want to edit the contribution associated with this membership to adjust its amount.'),
+          ts('Warning')
+        );
+      }
     }
   }