Nicklist faulty clickHandler fixed

No idea why it's fixed.. but a small cleanup seems to have done it :/

diff --git a/client/js/front.js b/client/js/front.js
index e5ab3e797383e23bd53602a2178d50b2868f9200..eaf2019740b5c22d9d72c6174e05648ee5e8a6d2 100644 (file)
--- a/client/js/front.js
+++ b/client/js/front.js
@@ -987,26 +987,30 @@ UserList.prototype.setWidth = function (newWidth) {
 */
 UserList.prototype.clickHandler = function () {
     var li = $(this).parent(),
-        user = li.data('user');
-
+        user = li.data('user'),
+        userbox;
+    
     // Remove any existing userboxes
     $('#kiwi .userbox').remove();
 
-    if ($(li).data('userbox') === this) {
-        $(li).removeData('userbox');
+    if (li.data('userbox') === true) {
+        // This li already has the userbox, show remove it instead
+        li.removeData('userbox');
+
     } else {
-        $('#tmpl_user_box').tmpl({nick: user.nick}).appendTo(li);
+        // We don't have a userbox so create one
+        userbox = $('#tmpl_user_box').tmpl({nick: user.nick}).appendTo(li);
 
-        $('#kiwi .userbox .userbox_query').click(function (ev) {
+        $('.userbox_query', userbox).click(function (ev) {
             var nick = $('#kiwi .userbox_nick').val();
             kiwi.front.run('/query ' + nick);
         });
 
-        $('#kiwi .userbox .userbox_whois').click(function (ev) {
+        $('.userbox_whois', userbox).click(function (ev) {
             var nick = $('#kiwi .userbox_nick').val();
             kiwi.front.run('/whois ' + nick);
         });
-        $(li).data('userbox', this);
+        li.data('userbox', true);
     }
 };