CRM-18356: Fix incorrect logic Activity Report has when excluding NULL / NOT NULL...
authorFrancis Whittle <francis@agileware.com.au>
Fri, 22 Apr 2016 05:11:53 +0000 (15:11 +1000)
committerAgileware Support <support@agileware.com.au>
Fri, 22 Apr 2016 05:15:34 +0000 (15:15 +1000)
----------------------------------------
* CRM-18356: Activity Reports show null Target Name fields incorrectly for some Activities
  https://issues.civicrm.org/jira/browse/CRM-18356

CRM/Report/Form/Activity.php

index 7a9372a15e022871d412c143f45277b750d9e974..67c4269f71967403084c2ad767029d51d7697f2b 100644 (file)
@@ -580,7 +580,7 @@ class CRM_Report_Form_Activity extends CRM_Report_Form {
           }
           else {
             $op = CRM_Utils_Array::value("{$fieldName}_op", $this->_params);
-            if ($op && ($op != 'nnll' || $op != 'nll')) {
+            if ($op && ($op != 'nnll' && $op != 'nll')) {
               $clause = $this->whereClause($field,
                 $op,
                 CRM_Utils_Array::value("{$fieldName}_value", $this->_params),