dev/core#562 remove more instances of ->free()
authoreileen <emcnaughton@wikimedia.org>
Thu, 7 Mar 2019 19:15:49 +0000 (08:15 +1300)
committereileen <emcnaughton@wikimedia.org>
Thu, 7 Mar 2019 19:15:49 +0000 (08:15 +1300)
commitfccb50a6ff8a6f35ae8933121ffcd5b57fc995c4
treeffef52a04d1cceef967a7f1b38641176a1ff2dd2
parentfc07aa1b8fe1e1f47399bf023510b57efab06ac4
dev/core#562 remove more instances of ->free()

Per https://lab.civicrm.org/dev/core/issues/562 we have been incrementally removing these as
1) we free resources on DAO->_destruct now and
2) in some edge cases freeing resources in an 'inner loop' can free outer loop
resources - resulting in a hard-to-analyse bug
CRM/Contribute/BAO/Contribution.php
CRM/Core/BAO/Cache.php
CRM/Core/BAO/SchemaHandler.php
CRM/Core/PrevNextCache/Redis.php