CRM-20036 Don't retrieve all soft contributions if not needed.
authoreileen <emcnaughton@wikimedia.org>
Sun, 26 Feb 2017 23:49:11 +0000 (12:49 +1300)
committereileen <emcnaughton@wikimedia.org>
Thu, 27 Apr 2017 01:10:30 +0000 (13:10 +1200)
commitfae6938759bcaff6dbc14ffa8b20feb97aba9d43
treef19118c97e4df058696dbc3564486ed952f0e565
parent257bb63e96fff13965ddb60ccf988bd360a0a454
CRM-20036 Don't retrieve all soft contributions if not needed.

This is an alternate fix to https://github.com/civicrm/civicrm-core/pull/9849 which basically removes the entire function. There appears to be only one place where it is called without id being set so we should simply require id & just handle that. In that one place we can use the api to do what the function was doing
CRM/Contribute/BAO/ContributionSoft.php
CRM/Contribute/Form/Contribution.php
CRM/Contribute/Import/Parser/Contribution.php
api/v3/ContributionSoft.php
tests/phpunit/api/v3/ContributionSoftTest.php