dev/financial#94 fix eroneous payment creation when editing line items
authoreileen <emcnaughton@wikimedia.org>
Wed, 30 Oct 2019 10:49:23 +0000 (23:49 +1300)
committereileen <emcnaughton@wikimedia.org>
Wed, 30 Oct 2019 10:49:23 +0000 (23:49 +1300)
commitfab405c86398fc3c3e075d55fdd7578d8cad1105
tree18544ba69263f68140ce0d75652cfc2ea63d24d8
parentb19a403d771544b388e201c2fd34822b10d57bfd
dev/financial#94 fix eroneous payment creation when editing line items

Per https://lab.civicrm.org/dev/financial/issues/94 an eroneous payment transaction is being created when an extra line is
added to an order. The code comments indicate that during the last refactoring the chunk of code
doing this was identified as highly suspect and on re-review of it I'm sure it should go
as we are altering the items purchases, not recording payment in this routine.

I think it dates back to an earlier concept of the flow where altering what was purchased implictly
altered the payments towards that purchase
CRM/Price/BAO/LineItem.php
tests/phpunit/CRM/Event/Form/ParticipantTest.php