[REF] replace isFirst parameter
authorEileen McNaughton <emcnaughton@wikimedia.org>
Tue, 25 May 2021 04:42:45 +0000 (16:42 +1200)
committerEileen McNaughton <emcnaughton@wikimedia.org>
Tue, 25 May 2021 04:44:06 +0000 (16:44 +1200)
commitf419011556c78c13b249b365a75d4750e1b275c6
tree193ca1364143061678f05fce749b6ff6e812da4d
parent48aaabb142b4c9847f2ce1ce510557a3718394ed
[REF] replace isFirst parameter

Here we see that the 2 paths to 'recur' were calculating isFirst slightly differently.

In one case (the dominant one) we were looking to see if it was completed whereas
in the lesser path (paypal express) we were looking to see if it was not pending.

That leaves
'cancelled' & 'failed' in a limbo. I think logically we can't complete either of those
so the dominant definition is better
CRM/Core/Payment/PayPalProIPN.php