Use consistent value for checkPermissions in merger
authorEileen McNaughton <emcnaughton@wikimedia.org>
Wed, 5 Jul 2023 01:10:35 +0000 (13:10 +1200)
committerEileen McNaughton <emcnaughton@wikimedia.org>
Wed, 5 Jul 2023 01:11:28 +0000 (13:11 +1200)
commite0e0010322ee937af94160087c5433928e1b6d9b
tree07a3cc2d8c7481744bb7c54d99a68794fb4c71d9
parentcb5222079a30e963e28dfb4f001222923e074340
Use consistent value for checkPermissions in merger

We recently added a permission check when retrieving metadata here
https://github.com/civicrm/civicrm-core/commit/0e88731ff38f4bcf5a4d53c7e2ced01f70533ff1#diff-fe60c89ebe94bbd40114d135459371cc53708db1f2952ade6c0ce9b3468c4dabR2306

However, when that function is called from getFieldValueAndLabel that is not being passed
and is defaulting to TRUE. This is causing issues in a cron context where
checkPermissions is being used (well actually in a unit test in our custom code
simulating that possiblility)
CRM/Dedupe/Merger.php